Add cloud provider name to infra config #145
Conversation
openshift-ci-robot
added
the
size/XS
config/v1/types_infrastructure.go
Outdated
| } | ||
|
|
||
| type InfrastructureSpec struct { | ||
| // CloudProvider is the IaaS provider that is running the cluster. The value |
config/v1/types_infrastructure.go
Outdated
| type InfrastructureSpec struct { | ||
| // CloudProvider is the IaaS provider that is running the cluster. The value | ||
| // should be a valid kubelet --cloud-provider value. | ||
| CloudProvider string `json:"cloudProvider,omitempty"` |
There was a problem hiding this comment.
You think this should be mutable? I expected it to be immutable.
There was a problem hiding this comment.
Yeah; is there more to do with docs or tags in that case?
There was a problem hiding this comment.
Relocated to status
config/v1/types_infrastructure.go
Outdated
| type InfrastructureStatus struct { | ||
| // type | ||
| // cloudProvider is the IaaS provider that is running the cluster. The value | ||
| // should be a valid kubelet --cloud-provider value. |
There was a problem hiding this comment.
@openshift/api-reviewers We should encourage documentation in config.openshift.io to stand alone and not depend on other binaries for their docs.
@ironcladlou in this case, this should list out the allowed values. Then it can be enforced in validation (something like openshift/origin#21679 or whatever we end up choosing).
Also, squash
ironcladlou
force-pushed
the
cloud-provider
branch
from
a352917 to
f70d4c4
Compare
Add a CloudProvider field to the infra config. This value is needed by at least: * kubelet * kube-controller-manager * kube-apiserver * openshift-ingress-operator This change does not intend to address the cloud provider configuration file API.
ironcladlou
force-pushed
the
cloud-provider
branch
from
f70d4c4 to
a8f58df
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cc @csrwng |
4 participants
Add a CloudProvider field to the infra config. This value is needed by at least:
This change does not intend to address the cloud provider configuration file
API.
/cc @openshift/sig-network-edge @derekwaynecarr @deads2k @rajatchopra @flaper87 @smarterclayton