Add asset for DNS config #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Contributor
Author
|
Still testing. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
This is largely cargo-culting from #717, so if there's better example to follow, please point me to it. |
Miciah
reviewed
Dec 17, 2018
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
|
Can you squash the fixup commit in? We also prefer having the vendor bump in it's own separate commit, to make it easier to distinguish between human- and machine-generated changes (see #717 for an example of this). But the vendor bump here is small enough that I'm fine leaving that in the same commit as the changes you wrote yourself if you don't want to bother splitting it out. |
Update openshift/api to a level which includes DNS config.
Add a `config.openshift.io/DNS` instance to the cluster to expose DNS configuration. * Update the `openshift/api` package to a version containing the new config type. * Generate the `config.openshift.io/DNS` custom resource definition manifest. * Generate the CRD instance manifest populated with base domain from the install config. This enables consumers of DNS configuration to migrate away from install config.
ironcladlou
force-pushed
the
basedomain
branch
from
78ccbef to
dd6d6d5
Compare
Contributor
Author
|
@wking my team also uses separate commits for dependency updates, so no problem... split dependency bump into a new commit and squashed other changes. PTAL |
Contributor
Author
|
@abhinavdahiya @wking @crawford PTAL, I have another one coming after this for cloud provider |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
2018/12/18 17:50:29 Copying artifacts from e2e-aws into /logs/artifacts/e2e-aws
2018/12/18 17:50:29 error: unable to signal to artifacts container to terminate in pod e2e-aws, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts")
2018/12/18 17:50:29 error: unable to retrieve artifacts from pod e2e-aws: could not read gzipped artifacts: unable to upgrade connection: container not found ("artifacts")
E1218 17:50:34.426002 11 event.go:203] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:".15717eae579f5fe6", GenerateName:"", Namespace:"ci-op-q60jbthr", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, InvolvedObject:v1.ObjectReference{Kind:"", Namespace:"ci-op-q60jbthr", Name:"", UID:"", APIVersion:"", ResourceVersion:"", FieldPath:""}, Reason:"CiJobFailed", Message:"Running job pull-ci-openshift-installer-master-e2e-aws for PR https://github.com/openshift/installer/pull/934 in namespace ci-op-q60jbthr from author ironcladlou", Source:v1.EventSource{Component:"ci-op-q60jbthr", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0xbefe6aba9949bbe6, ext:11451145957064, loc:(*time.Location)(0x19f83a0)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xbefe6aba9949bbe6, ext:11451145957064, loc:(*time.Location)(0x19f83a0)}}, Count:1, Type:"Warning", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events ".15717eae579f5fe6" is forbidden: unable to create new content in namespace ci-op-q60jbthr because it is being terminated' (will not retry!)
2018/12/18 17:50:35 Ran for 3h10m52s
error: could not run steps: could not wait for pod to complete: could not wait for pod completion: pod e2e-aws was already deletedHmm 😕 /retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/cc @csrwng |
Contributor
|
the worker node never joined... show that the instance was created. @aveshagarwal also say this happening on his cluster. |
Contributor
|
Not sure it's relevant, but the operator is getting throttled by AWS when trying to look up the hosted zone, although it succeeds after a few minutes: The above repeats 16 times before reconciliation eventually succeeds: |
Contributor
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
config.openshift.io/DNSinstance to the cluster to expose DNS configuration.openshift/apipackage to a version containing the new config type.config.openshift.io/DNScustom resource definition manifest.This enables consumers of DNS configuration to migrate away from install config.
Related to openshift/api#146.
/cc @openshift/sig-network-edge