Bug 2069457: Delete LoadBalancer-type service finalizer logic #729
Conversation
openshift-ci
bot
added
the
bugzilla/severity-low
|
@Miciah: This pull request references Bugzilla bug 2069457, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
added
the
approved
Delete the deletion logic for the "ingress.openshift.io/operator" finalizer for LoadBalancer-type services. This finalizer has not been needed since OpenShift 4.2, when the DNSRecord CRD was added. OpenShift 4.8 removed the logic that added the finalizer and added logic to remove the finalizer. Thus with OpenShift versions after OpenShift 4.8, this finalizer no longer exists, and the corresponding logic can be deleted. Follow-up to commit 081081a. This commit fixes bug 2069457. https://bugzilla.redhat.com/show_bug.cgi?id=2069457 * pkg/manifests/manifests.go (LoadBalancerServiceFinalizer): Delete const. * pkg/operator/controller/ingress/controller.go (ensureIngressDeleted): Delete calls to finalizeLoadBalancerService. * pkg/operator/controller/ingress/load_balancer_service.go (ensureLoadBalancerService): Delete calls to deleteLoadBalancerService. (deleteLoadBalancerService, finalizeLoadBalancerService): Delete methods.
Miciah
force-pushed
the
BZ2069457-delete-LoadBalancer-type-service-finalizer-logic
branch
from
7ce23d5 to
7749fcf
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 2069457 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.10 |
1 similar comment
|
/cherry-pick release-4.10 |
|
@gcs278: new pull request created: #755 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
1 similar comment
|
/cherry-pick release-4.9 |
|
@gcs278: new pull request created: #771 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Delete the deletion logic for the "ingress.openshift.io/operator" finalizer for LoadBalancer-type services. This finalizer has not been needed since OpenShift 4.2, when the DNSRecord CRD was added. OpenShift 4.8 removed the logic that added the finalizer and added logic to remove the finalizer. Thus with OpenShift versions after OpenShift 4.8, this finalizer no longer exists, and the corresponding logic can be deleted.
Follow-up to #549.
pkg/manifests/manifests.go(LoadBalancerServiceFinalizer): Delete const.pkg/operator/controller/ingress/controller.go(ensureIngressDeleted): Delete calls tofinalizeLoadBalancerService.pkg/operator/controller/ingress/load_balancer_service.go(ensureLoadBalancerService): Delete calls todeleteLoadBalancerService.(
deleteLoadBalancerService,finalizeLoadBalancerService): Delete methods.