[release-4.9] Bug 2094054: Delete LoadBalancer-type service finalizer logic by openshift-cherrypick-robot · Pull Request #771 · openshift/cluster-ingress-operator

openshift-cherrypick-robot · 2022-06-06T17:22:20Z

This is an automated cherry-pick of #729

/assign gcs278

Delete the deletion logic for the "ingress.openshift.io/operator" finalizer for LoadBalancer-type services. This finalizer has not been needed since OpenShift 4.2, when the DNSRecord CRD was added. OpenShift 4.8 removed the logic that added the finalizer and added logic to remove the finalizer. Thus with OpenShift versions after OpenShift 4.8, this finalizer no longer exists, and the corresponding logic can be deleted. Follow-up to commit 081081a. This commit fixes bug 2069457. https://bugzilla.redhat.com/show_bug.cgi?id=2069457 * pkg/manifests/manifests.go (LoadBalancerServiceFinalizer): Delete const. * pkg/operator/controller/ingress/controller.go (ensureIngressDeleted): Delete calls to finalizeLoadBalancerService. * pkg/operator/controller/ingress/load_balancer_service.go (ensureLoadBalancerService): Delete calls to deleteLoadBalancerService. (deleteLoadBalancerService, finalizeLoadBalancerService): Delete methods.

openshift-ci · 2022-06-06T17:22:33Z

@openshift-cherrypick-robot: Bugzilla bug 2069457 has been cloned as Bugzilla bug 2094054. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2094054: Delete LoadBalancer-type service finalizer logic

Details

In response to this:

[release-4.9] Bug 2069457: Delete LoadBalancer-type service finalizer logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-06T17:22:42Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2094054, which is invalid:

expected dependent Bugzilla bug 2069457 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.9] Bug 2094054: Delete LoadBalancer-type service finalizer logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-06T19:44:40Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Miciah · 2022-06-06T22:40:09Z

/lgtm

openshift-ci · 2022-06-06T22:40:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-06-07T01:00:51Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-06-07T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 2094054, which is invalid:

expected dependent Bugzilla bug 2069457 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-06-08T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-06-08T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 2094054, which is invalid:

expected dependent Bugzilla bug 2069457 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2022-06-08T01:44:01Z

/bugzilla refresh

openshift-ci · 2022-06-08T01:44:10Z

@lihongan: This pull request references Bugzilla bug 2094054, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2082161 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2082161 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2022-06-08T01:47:11Z

/label qe-approved

lihongan · 2022-06-08T01:47:18Z

/label cherry-pick-approved

openshift-ci · 2022-06-08T01:48:54Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#771

Bugzilla bug 2094054 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2094054: Delete LoadBalancer-type service finalizer logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Jun 6, 2022

Bug 2069457: Delete LoadBalancer-type service finalizer logic #729

Merged

openshift-ci bot assigned gcs278 Jun 6, 2022

openshift-ci bot changed the title ~~[release-4.9] Bug 2069457: Delete LoadBalancer-type service finalizer logic~~ [release-4.9] Bug 2094054: Delete LoadBalancer-type service finalizer logic Jun 6, 2022

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 6, 2022

openshift-ci bot requested review from lmzuccarelli and rfredette June 6, 2022 17:22

Miciah added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 6, 2022

openshift-ci bot assigned lihongan, melvinjoseph86, quarterpin and ShudiLi Jun 6, 2022

openshift-ci bot assigned Miciah Jun 6, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022

openshift-ci bot requested a review from lihongan June 8, 2022 01:44

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 8, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 8, 2022

openshift-merge-robot merged commit b59abfc into openshift:release-4.9 Jun 8, 2022

Conversation

openshift-cherrypick-robot commented Jun 6, 2022

Uh oh!

openshift-ci bot commented Jun 6, 2022

Uh oh!

openshift-ci bot commented Jun 6, 2022

Uh oh!

openshift-ci bot commented Jun 6, 2022

Uh oh!

Miciah commented Jun 6, 2022

Uh oh!

openshift-ci bot commented Jun 6, 2022

Uh oh!

openshift-bot commented Jun 7, 2022

Uh oh!

openshift-ci bot commented Jun 7, 2022

Uh oh!

openshift-bot commented Jun 8, 2022

Uh oh!

openshift-ci bot commented Jun 8, 2022

Uh oh!

lihongan commented Jun 8, 2022

Uh oh!

openshift-ci bot commented Jun 8, 2022

Uh oh!

lihongan commented Jun 8, 2022

Uh oh!

lihongan commented Jun 8, 2022

Uh oh!

openshift-ci bot commented Jun 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants