BUG 2054200: Fix removing custom created service in openshift-ingress with same name by gcs278 · Pull Request #707 · openshift/cluster-ingress-operator

gcs278 · 2022-02-24T02:31:08Z

If custom created service in the openshift-ingress namespace has the same naming convention of what the ingress controllers uses, it will be deleted. This fix ensures that the only services that get deleted are owned by the ingress controller responsible for creating it.

openshift-ci · 2022-02-24T02:31:16Z

@gcs278: This pull request references Bugzilla bug 2054200, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] BUG 2054200: Fix removing custom created service in openshift-ingress with same name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-02-28T14:43:36Z

/retest

gcs278 · 2022-03-01T18:11:09Z

/bugzilla refresh

openshift-ci · 2022-03-01T18:11:16Z

@gcs278: This pull request references Bugzilla bug 2054200, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @quarterpin

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-03-01T19:19:29Z

/retest

gcs278 · 2022-03-01T21:25:12Z

/retest

gcs278 · 2022-03-01T23:40:54Z

/retest

test/e2e/operator_test.go

gcs278 · 2022-03-03T17:04:35Z

/retest

gcs278 · 2022-03-03T17:59:43Z

/retest

gcs278 · 2022-03-03T18:34:40Z

/retest

gcs278 · 2022-03-03T20:41:34Z

/retest

gcs278 · 2022-03-03T22:09:58Z

/retest

gcs278 · 2022-03-04T13:55:23Z

/retest

gcs278 · 2022-03-04T15:38:45Z

/retest

gcs278 · 2022-04-18T18:31:38Z

/retest

quarterpin · 2022-04-20T08:36:47Z

/label qe-approved
Verified via pre-merge test process. For more details refer to: https://bugzilla.redhat.com/show_bug.cgi?id=2054200#c6

Miciah

Looks good overall. I have a few small suggestions.

pkg/operator/controller/ingress/load_balancer_service.go

pkg/operator/controller/ingress/load_balancer_service_test.go

test/e2e/operator_test.go

pkg/operator/controller/ingress/load_balancer_service.go

… with same naming convention

Miciah · 2022-04-21T19:54:58Z

/lgtm

openshift-ci · 2022-04-21T19:55:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,gcs278]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gcs278 · 2022-04-21T22:37:29Z

/retest

openshift-bot · 2022-04-22T00:02:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-22T02:17:02Z

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-04-22T02:18:36Z

@gcs278: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#707

Bugzilla bug 2054200 has been moved to the MODIFIED state.

Details

In response to this:

BUG 2054200: Fix removing custom created service in openshift-ingress with same name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-05-05T14:18:51Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-05-05T14:19:27Z

@gcs278: #707 failed to apply on top of branch "release-4.10":

Applying: BUG 2054200: Fix removing custom created service in openshift-ingress with same naming convention
Using index info to reconstruct a base tree...
M	pkg/operator/controller/ingress/load_balancer_service.go
M	pkg/operator/controller/ingress/load_balancer_service_test.go
M	test/e2e/operator_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/operator_test.go
CONFLICT (content): Merge conflict in test/e2e/operator_test.go
Auto-merging pkg/operator/controller/ingress/load_balancer_service_test.go
Auto-merging pkg/operator/controller/ingress/load_balancer_service.go
CONFLICT (content): Merge conflict in pkg/operator/controller/ingress/load_balancer_service.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BUG 2054200: Fix removing custom created service in openshift-ingress with same naming convention
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-06-06T17:06:25Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-06-06T17:07:08Z

@gcs278: new pull request created: #770

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-09-12T23:47:55Z

/cherry-pick release-4.9

gcs278 · 2022-09-12T23:53:30Z

/cherry-pick release-4.9

gcs278 · 2022-09-21T22:51:50Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2022-09-21T22:52:33Z

@gcs278: new pull request created: #831

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Feb 24, 2022

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 24, 2022

openshift-ci bot requested review from Miciah and miheer February 24, 2022 02:31

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022

gcs278 force-pushed the master branch 2 times, most recently from 27bb961 to 998c28e Compare March 1, 2022 17:03

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 1, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 1, 2022

openshift-ci bot requested a review from quarterpin March 1, 2022 18:11

gcs278 changed the title ~~[WIP] BUG 2054200: Fix removing custom created service in openshift-ingress with same name~~ BUG 2054200: Fix removing custom created service in openshift-ingress with same name Mar 2, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022

Miciah reviewed Mar 2, 2022

View reviewed changes

test/e2e/operator_test.go Outdated Show resolved Hide resolved

Miciah mentioned this pull request Mar 3, 2022

[release-4.9] Bug 2060111: Set Upgradeable=False if default cert has no SAN #711

Merged

gcs278 force-pushed the master branch from 998c28e to 5191262 Compare March 3, 2022 16:11

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 20, 2022

Miciah reviewed Apr 20, 2022

View reviewed changes

gcs278 force-pushed the BZ2054200-Rebase branch 2 times, most recently from 0db4b10 to 1409927 Compare April 21, 2022 19:28

BUG 2054200: Fix removing custom created service in openshift-ingress…

dba837a

… with same naming convention

gcs278 force-pushed the BZ2054200-Rebase branch from 1409927 to dba837a Compare April 21, 2022 19:38

openshift-ci bot assigned Miciah Apr 21, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022

openshift-merge-robot merged commit d637e6c into openshift:master Apr 22, 2022

openshift-cherrypick-robot mentioned this pull request Jun 6, 2022

[release-4.10] BUG 2094051: Fix removing custom created service in openshift-ingress with same name #770

Closed

This was referenced Jun 16, 2022

[release-4.10] Bug 2097735: Fix loadBalancerServiceAnnotationsChanged check and update #784

Merged

[release-4.9] Bug 2097736: Fix loadBalancerServiceAnnotationsChanged check and update #786

Merged

gcs278 mentioned this pull request Aug 26, 2022

[release-4.10] BUG 2094051: Fix removing custom created service in openshift-ingress with same naming convention #820

Merged

openshift-cherrypick-robot mentioned this pull request Sep 21, 2022

[release-4.9] OCPBUGS-1624: Fix removing custom created service in openshift-ingress with same name #831

Merged

Conversation

gcs278 commented Feb 24, 2022

Uh oh!

openshift-ci bot commented Feb 24, 2022

Uh oh!

gcs278 commented Feb 28, 2022

Uh oh!

gcs278 commented Mar 1, 2022

Uh oh!

openshift-ci bot commented Mar 1, 2022

Uh oh!

gcs278 commented Mar 1, 2022

Uh oh!

gcs278 commented Mar 1, 2022

Uh oh!

gcs278 commented Mar 1, 2022

Uh oh!

Uh oh!

gcs278 commented Mar 3, 2022

Uh oh!

gcs278 commented Mar 3, 2022

Uh oh!

gcs278 commented Mar 3, 2022

Uh oh!

gcs278 commented Mar 3, 2022

Uh oh!

gcs278 commented Mar 3, 2022

Uh oh!

gcs278 commented Mar 4, 2022

Uh oh!

gcs278 commented Mar 4, 2022

Uh oh!

gcs278 commented Apr 18, 2022

Uh oh!

quarterpin commented Apr 20, 2022

Uh oh!

Miciah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Miciah commented Apr 21, 2022

Uh oh!

openshift-ci bot commented Apr 21, 2022

Uh oh!

gcs278 commented Apr 21, 2022

Uh oh!

openshift-bot commented Apr 22, 2022

Uh oh!

openshift-ci bot commented Apr 22, 2022

Uh oh!

openshift-ci bot commented Apr 22, 2022

Uh oh!

gcs278 commented May 5, 2022

Uh oh!

openshift-cherrypick-robot commented May 5, 2022

Uh oh!

gcs278 commented Jun 6, 2022

Uh oh!

openshift-cherrypick-robot commented Jun 6, 2022

Uh oh!

gcs278 commented Sep 12, 2022

Uh oh!

gcs278 commented Sep 12, 2022

Uh oh!

gcs278 commented Sep 21, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone