Skip to content

Fix yaml patch#688

Closed
Elbehery wants to merge 2 commits intoopenshift:masterfrom
Elbehery:fix-yaml-patch
Closed

Fix yaml patch#688
Elbehery wants to merge 2 commits intoopenshift:masterfrom
Elbehery:fix-yaml-patch

Conversation

@Elbehery
Copy link
Copy Markdown

This PR bumps in newer version of https://github.com/openshift/build-machinery-go

This PR fixes an issue with make verify on this repo

@Elbehery
Copy link
Copy Markdown
Author

cc @arjunrn @lmzuccarelli

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery
To complete the pull request process, please assign miciah after the PR has been reviewed.
You can assign the PR to them by writing /assign @miciah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from candita and knobunc December 14, 2021 11:55
@frobware
Copy link
Copy Markdown
Contributor

We also have #687 as a fix. I prefer 687 as we would drop some dependencies.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2021

@Elbehery: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify b304434 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Elbehery
Copy link
Copy Markdown
Author

closing this with #687

@Elbehery Elbehery closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants