[release-4.9] Bug 2014711: Fix for Azure dns privateZone degrade e2e test#664
Conversation
|
@openshift-cherrypick-robot: Bugzilla bug 2014710 has been cloned as Bugzilla bug 2014711. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci
bot
added
the
bugzilla/severity-high
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014711, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014711, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Miciah
added
the
backport-risk-assessed
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@Miciah: This pull request references Bugzilla bug 2014711, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| } else { | ||
| // remove 'error-' from prefix | ||
| // remove injectError from prefix | ||
| dnsConfig.Spec.PrivateZone.ID = dnsConfig.Spec.PrivateZone.ID[6:] |
There was a problem hiding this comment.
Better to use len(injectError) instead of 6.
| } else { | ||
| // remove 'error-' from prefix | ||
| // remove injectError from prefix | ||
| dnsConfig.Spec.PrivateZone.Tags["Name"] = dnsConfig.Spec.PrivateZone.Tags["Name"][6:] |
There was a problem hiding this comment.
Better to use len(injectError) instead of 6.
|
Closing in favor of #673. |
|
@Miciah: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014711. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This is an automated cherry-pick of #662
/assign Miciah
The recently added
TestIngressStatustest fails on Azure, causing the e2e-azure-operator CI jobs in the cluster-ingress-operator repository to fail consistently. This backport fixes the test so that it passes on Azure. This is needed so that we can verify cluster-ingress-operator PRs to the release-4.9 branch on Azure. This change has no direct impact on users.