Skip to content

Bug 2014710: test/e2e: updateDNSConfig: Replace integer literals#672

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Miciah:test-slash-e2e-updateDNSConfig-replace-integer-literals
Nov 2, 2021
Merged

Bug 2014710: test/e2e: updateDNSConfig: Replace integer literals#672
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Miciah:test-slash-e2e-updateDNSConfig-replace-integer-literals

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Nov 2, 2021

Follow-up to fe8c1ee based on review comments on the release-4.9 backport: #664 (review)

  • test/e2e/dns_ingressdegrade_test.go (updateDNSConfig): Replace integer literals with len(injectError). Change injectError to a const.

Follow-up to commit fe8c1ee.

* test/e2e/dns_ingressdegrade_test.go (updateDNSConfig): Replace integer
literals with len(injectError).  Change injectError to a const.
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

@Miciah: This pull request references Bugzilla bug 2014710, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2014710: test/e2e: updateDNSConfig: Replace integer literals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 2, 2021
@openshift-ci openshift-ci bot requested review from frobware and rfredette November 2, 2021 02:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@Miciah
Copy link
Contributor Author

Miciah commented Nov 2, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

@Miciah: This pull request references Bugzilla bug 2014710, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor

frobware commented Nov 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 417ec35 into openshift:master Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 2014710 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2014710: test/e2e: updateDNSConfig: Replace integer literals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants