Bug 2014710: test/e2e: updateDNSConfig: Replace integer literals#672
Conversation
Follow-up to commit fe8c1ee. * test/e2e/dns_ingressdegrade_test.go (updateDNSConfig): Replace integer literals with len(injectError). Change injectError to a const.
|
@Miciah: This pull request references Bugzilla bug 2014710, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@Miciah: This pull request references Bugzilla bug 2014710, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 2014710 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Follow-up to fe8c1ee based on review comments on the release-4.9 backport: #664 (review)
test/e2e/dns_ingressdegrade_test.go(updateDNSConfig): Replace integer literals withlen(injectError). ChangeinjectErrorto a const.