Bug 2014710: Fix for Azure dns privateZone degrade e2e test

[lmzuccarelli]

This fix ensures the e2e test for dns privateZone works for Azure , GCP and AWS.

The fix is really simple. Azure uses a "/" naming notation for privateZones, the original "error-" prefix did not cause a failure, the updated prefix injected is simply "/error" which causes the operator status to degrade to TRUE

The change was verified on Azure & AWS via cluster-bot

For Azure

GO111MODULE=on GOFLAGS=-mod=vendor go test -timeout 1h -count 1 -v -tags e2e -run "TestIngressStatus" ./test/e2e/                                                                                                       
I1015 12:27:32.540041 1235696 request.go:668] Waited for 1.046809151s due to client-side throttling, not priority and fairness, request: GET:https://api.ci-ln-zjdbpyt-002ac.ci.azure.devcluster.openshift.com:6443/apis/controlplane.operator.openshift.io/v1alpha1?timeout=32s
=== RUN   TestIngressStatus
--- PASS: TestIngressStatus (33.69s)
PASS
ok  	github.com/openshift/cluster-ingress-operator/test/e2e	37.117s

For AWS

GO111MODULE=on GOFLAGS=-mod=vendor go test -timeout 1h -count 1 -v -tags e2e -run "TestIngressStatus" ./test/e2e                                                                                       
I1015 14:04:16.269989    9695 request.go:668] Waited for 1.045602401s due to client-side throttling, not priority and fairness, request: GET:https://api.ci-ln-53wq70b-d5d6b.origin-ci-int-aws.dev.rhcloud.com:6443/apis/apiserver.openshift.io/v1?timeout=32s
=== RUN   TestIngressStatus
--- PASS: TestIngressStatus (35.77s)
PASS
ok  	github.com/openshift/cluster-ingress-operator/test/e2e	39.560s

[lmzuccarelli]

/test e2e-aws

[Miciah]

Thanks! We might as well check that the full test suite passes on Azure:
/test e2e-azure-operator

[Miciah]

Tests look good. Thanks!
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmzuccarelli, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Miciah,lmzuccarelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miciah]

In retrospect, we should have a BZ linked to this PR so that we can backport the fix to the release-4.9, where the test was first introduced.

[Miciah]

/retitle Bug 2014710: Fix for Azure dns privateZone degrade e2e test

[openshift-ci]

@lmzuccarelli: All pull requests linked via external trackers have merged:

Bugzilla bug 2014710 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2014710: Fix for Azure dns privateZone degrade e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

/cherry-pick release-4.9

[openshift-cherrypick-robot]

@Miciah: new pull request created: #664

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.