[release-4.15] OCPBUGS-28928: Prevent upgrades for SHA1 default cert and SHA1 route certs

[gcs278]

Note: This is NOT a backport or cherry-pick of any commits, but instead a discrete PR targeting 4.15.

This PR handles SHA1 certificate upgradeable scenarios for 4.15. With OpenSSL3.0 provided by RHEL9 in 4.16, the router will fail to start if any cert provided is SHA1.

First, if the default certificate on the Ingress Controller object is using SHA1, then set Upgradeable to be False.

Secondly, add a new control loop, route deprecated, that determines upgradeablity by searching for the UnservableInFutureVersions condition in the routes. The UnservableInFutureVersions will be added to the route by openshift/router#555 when a SHA1 certificate exists on the route. It creates an admin-gate if a UnservableInFutureVersions condition is found. This logic assumes any UnservableInFutureVersions route status condition is an upgrade blocker.

This implementation targets 4.15 to 4.16 updates specifically, so it is only targeting the release-4.15 branch and we will be merged in the backport of https://issues.redhat.com/browse/OCPBUGS-26498. The code should not be merged into 4.16.

This PR leveraged logic from openshift/vmware-vsphere-csi-driver-operator#171.

This PR depends on openshift/router#585 for E2E test to succeed.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

If the default certificate is using SHA1, then set Upgradeable to be False. With OpenSSL3.0 provided by RHEL9, the router will fail to start if any cert provided is SHA1.

This commit also removes the logic for setting Upgradeable to be False if the default cert has no SAN. This logic is unnecessary as of OCP 4.10.

pkg/operator/controller/ingress/status.go: Refactor checkDefaultCertificate to check for SHA1-based certs.
pkg/operator/controller/ingress/status_test.go: Add test coverage to Test_computeIngressUpgradeableCondition for SHA1-based certs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

If the default certificate is using SHA1, then set Upgradeable to be False. With OpenSSL3.0 provided by RHEL9, the router will fail to start if any cert provided is SHA1.

This commit also removes the logic for setting Upgradeable to be False if the default cert has no SAN. This logic is unnecessary as of OCP 4.10.

pkg/operator/controller/ingress/status.go: Refactor checkDefaultCertificate to check for SHA1-based certs.
pkg/operator/controller/ingress/status_test.go: Add test coverage to Test_computeIngressUpgradeableCondition for SHA1-based certs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR handles SHA1 certificate upgradeable scenarios for 4.15. With OpenSSL3.0 provided by RHEL9 in 4.16, the router will fail to start if any cert provided is SHA1.

First, if the default certificate on the Ingress Controller object is using SHA1, then set Upgradeable to be False. Also remove the logic for setting Upgradeable to be False if the default cert has no SAN. This logic is unnecessary as of OCP 4.10.

Secondly, add a new control loop, route deprecated, that determines upgradeablity by searching for the Deprecated condition in the routes. The Deprecated will be added to the route by openshift/router#555 when a SHA1 certificate exists on the route. It creates an admin-gate if a Deprecated condition is found. This logic assumes any Deprecated route status condition is an upgrade blocker.

This implementation targets 4.15 to 4.16 updates specifically, so will need to be backported to 4.15 to be useful. It can later be removed in 4.16+ as it will be no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is invalid:

• expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.16.0" instead
• expected Jira Issue OCPBUGS-26498 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This PR handles SHA1 certificate upgradeable scenarios for 4.15. With OpenSSL3.0 provided by RHEL9 in 4.16, the router will fail to start if any cert provided is SHA1.

First, if the default certificate on the Ingress Controller object is using SHA1, then set Upgradeable to be False. Also remove the logic for setting Upgradeable to be False if the default cert has no SAN. This logic is unnecessary as of OCP 4.10.

Secondly, add a new control loop, route deprecated, that determines upgradeablity by searching for the Deprecated condition in the routes. The Deprecated will be added to the route by openshift/router#555 when a SHA1 certificate exists on the route. It creates an admin-gate if a Deprecated condition is found. This logic assumes any Deprecated route status condition is an upgrade blocker.

This implementation targets 4.15 to 4.16 updates specifically, so will need to be backported to 4.15 to be useful. It can later be removed in 4.16+ as it will be no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Miciah]

Thanks for the quick updates!
/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miciah]

This is fairly low risk. The changes are scoped to a small refactoring in the route-metrics controller, a new route-upgradeable controller, and a new upgradeability check, all of which have good test coverage.

/label backport-risk-assessed

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 37f7c42 and 2 for PR HEAD 6778ce1 in total

[wking]

Flake?

=== NAME  TestAll/parallel/TestIngressControllerRouteSelectorUpdateShouldClearRouteStatus
    panic.go:522: deleted ingresscontroller ic-route-selector-test

/test e2e-azure-operator

[gcs278]

@wking Yea it's caused by quite a simple problem and not related to this PR:

    router_status_test.go:134: failed to update ingresscontroller: Operation cannot be fulfilled on ingresscontrollers.operator.openshift.io "ic-route-selector-test": the object has been modified; please apply your changes to the latest version and try again

I'll make a bug eventually so NE can track this flake.

[ShudiLi]

/label qe-approved
tested it with 4.15.0-0.ci.test-2024-06-12-014748-ci-ln-hmf17h2-latest(the upgrade test will be done after the PRs are merged)

1.
% oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.15.0-0.ci.test-2024-06-12-014748-ci-ln-hmf17h2-latest   True        False         18m     Cluster version is 4.15.0-0.ci.test-2024-06-12-014748-ci-ln-hmf17h2-latest

2.
% oc -n openshift-ingress-operator -c ingress-operator rsync ingress-operator-c89797b65-7kqqc:/usr/bin/ingress-operator .
receiving file list ... done
ingress-operator

sent 38 bytes  received 95493821 bytes  7639508.72 bytes/sec
total size is 95470416  speedup is 1.00

3.
% go version -m ingress-operator | grep github.com/openshift/api 
	dep	github.com/openshift/api	v3.9.1-0.20190924102528-32369d4db2ad+incompatible
	=>	github.com/openshift/api	v0.0.0-20240522145529-93d6bda14341

[ShudiLi]

/test e2e-gcp-operator

[ShudiLi]

/label cherry-pick-approved

[openshift-ci]

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@gcs278: Jira Issue OCPBUGS-28928: All pull requests linked via external trackers have merged:

• openshift/cluster-ingress-operator#1014
• openshift/api#1751
• openshift/router#585
• openshift/origin#28820
• openshift/openshift-apiserver#436

Jira Issue OCPBUGS-28928 has been moved to the MODIFIED state.

Details

In response to this:

Note: This is NOT a backport or cherry-pick of any commits, but instead a discrete PR targeting 4.15.

This PR handles SHA1 certificate upgradeable scenarios for 4.15. With OpenSSL3.0 provided by RHEL9 in 4.16, the router will fail to start if any cert provided is SHA1.

First, if the default certificate on the Ingress Controller object is using SHA1, then set Upgradeable to be False.

Secondly, add a new control loop, route deprecated, that determines upgradeablity by searching for the UnservableInFutureVersions condition in the routes. The UnservableInFutureVersions will be added to the route by openshift/router#555 when a SHA1 certificate exists on the route. It creates an admin-gate if a UnservableInFutureVersions condition is found. This logic assumes any UnservableInFutureVersions route status condition is an upgrade blocker.

This implementation targets 4.15 to 4.16 updates specifically, so it is only targeting the release-4.15 branch and we will be merged in the backport of https://issues.redhat.com/browse/OCPBUGS-26498. The code should not be merged into 4.16.

This PR leveraged logic from openshift/vmware-vsphere-csi-driver-operator#171.

This PR depends on openshift/router#585 for E2E test to succeed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.15.0-202406120537.p0.ga0ac804.assembly.stream.el9 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-06-12-223752