Skip to content

OCPBUGS-28928: Bump openshift/api to get updated docs for UnservableInFutureVersions#436

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
gcs278:OCPBUGS-26498-unservableinfutureversions-4.15
Jun 12, 2024
Merged

OCPBUGS-28928: Bump openshift/api to get updated docs for UnservableInFutureVersions#436
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
gcs278:OCPBUGS-26498-unservableinfutureversions-4.15

Conversation

@gcs278
Copy link
Contributor

@gcs278 gcs278 commented May 22, 2024

Bump openshift/api to get updated docs for UnservableInFutureVersions which updates oc explain route.status.ingress.conditions.type.

  go get github.com/openshift/api@93d6bda14341f1d18319774367829c3278c171e7
  go mod tidy
  go mod vendor
  make update

This is a 4.15 backported API: openshift/api#1751

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 22, 2024
@openshift-ci-robot
Copy link

@gcs278: This pull request references Jira Issue OCPBUGS-28928, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-26498 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-26498 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump openshift/api to get updated docs for UnservableInFutureVersions which updates oc explain route.status.ingress.conditions.type.

 go get github.com/openshift/api@93d6bda14341f1d18319774367829c3278c171e7
 go mod tidy
 go mod vendor
 make update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ShudiLi, benluddy and bparees May 22, 2024 16:43
Bump openshift/api to get updated docs for UnservableInFutureVersions
which updates `oc explain route.status.ingress.conditions.type`.

  go get github.com/openshift/api@93d6bda14341f1d18319774367829c3278c171e7
  go mod tidy
  go mod vendor
  make update

Vendors openshift/api#1751
@gcs278 gcs278 force-pushed the OCPBUGS-26498-unservableinfutureversions-4.15 branch from 124cc37 to 3fc300d Compare May 30, 2024 17:03
@ShudiLi
Copy link
Member

ShudiLi commented May 31, 2024

/label qe-approved

tested it with 4.15.0-0.test-2024-05-31-031732-ci-ln-jchbdg2-latest, tested the go version of the openshift-apiserver and some CRDs

1.
% go version -m openshift-apiserver | grep github.com/openshift/api
        dep     github.com/openshift/api        v0.0.0-20240522145529-93d6bda14341
        dep     github.com/openshift/apiserver-library-go       v0.0.0-20230503174907-d9b2bf6185e9

2.
% oc get crd cloudprivateipconfigs.cloud.network.openshift.io -oyaml -o=jsonpath="{.spec..metadata}"
{"properties":{"name":{"anyOf":[{"format":"ipv4"},{"pattern":"^[0-9a-f]{4}(\\.[0-9a-f]{4}){7}$"}],"type":"string"}},"type":"object"}%

3.
% oc get crd clusterversions.config.openshift.io
NAME                                  CREATED AT
clusterversions.config.openshift.io   2024-05-31T03:52:03Z

4.
% oc get crd clusterversions.config.openshift.io -oyaml | grep -E "release.openshift.io|CloudCredential|x-kubernetes-list"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
    release.openshift.io/feature-set: Default
                      - CloudCredential
                    x-kubernetes-list-type: atomic
                x-kubernetes-list-map-keys:
                x-kubernetes-list-type: map
                      x-kubernetes-list-type: set
                x-kubernetes-list-type: atomic
                      - CloudCredential
                    x-kubernetes-list-type: atomic
                      - CloudCredential
                    x-kubernetes-list-type: atomic
                      x-kubernetes-list-map-keys:
                      x-kubernetes-list-type: map
                          x-kubernetes-list-type: set
                            x-kubernetes-list-type: atomic
                      x-kubernetes-list-map-keys:
                      x-kubernetes-list-type: map
                x-kubernetes-list-type: atomic
                x-kubernetes-list-map-keys:
                x-kubernetes-list-type: map
                    x-kubernetes-list-type: set


@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 31, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2024

@ShudiLi: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShudiLi
Copy link
Member

ShudiLi commented May 31, 2024

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2024

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor

frobware commented Jun 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@tkashem
Copy link
Contributor

tkashem commented Jun 3, 2024

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 3, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, gcs278, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@ShudiLi
Copy link
Member

ShudiLi commented Jun 12, 2024

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

@ShudiLi: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lihongan
Copy link

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

@lihongan: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xingxingxia
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ebb067d into openshift:release-4.15 Jun 12, 2024
@openshift-ci-robot
Copy link

@gcs278: Jira Issue OCPBUGS-28928: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28928 has not been moved to the MODIFIED state.

Details

In response to this:

Bump openshift/api to get updated docs for UnservableInFutureVersions which updates oc explain route.status.ingress.conditions.type.

 go get github.com/openshift/api@93d6bda14341f1d18319774367829c3278c171e7
 go mod tidy
 go mod vendor
 make update

This is a 4.15 backported API: openshift/api#1751

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openshift-apiserver-container-v4.15.0-202406120336.p0.gebb067d.assembly.stream.el9 for distgit ose-openshift-apiserver.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-06-12-223752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.