OCPBUGS-28928: Add test for UpgradeValidation contention #28820
Conversation
gcs278
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@gcs278: This pull request references Jira Issue OCPBUGS-28928, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gcs278
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
gcs278
force-pushed
the
OCPBUGS-26498-upgradeable-status-4.15
branch
from
415f006 to
76880df
Compare
|
/assign @frobware |
Bump openshift/api to get new route UnservableInFutureVersions status condition type. go get github.com/openshift/api@93d6bda14341f1d18319774367829c3278c171e7 go mod tidy go mod vendor Vendors openshift/api#1751
This updates the router status test write watch logic to use an informer, which allows for comparison of the old and new route objects along with the ability to start the informer in a separate go routine. The ability to compare the incoming change allows us to add filtering to make sure only the updates for our test router are counted. This greatly simplifies the logic because previously we couldn't filter out other router updates. As a result, we can remove the logic which waits for other routers to write status to our test routes. The informer is now started asynchronously before the routes are created. This allows us to accurately count all route updates. Previously, the test routes would be created and then the watch routine would start immediately after, which leads to the watch missing some updates.
Add "The HAProxy router converges when multiple routers are writing conflicting upgrade validation status" test which validates router converge when writing conflicting status in a scenario that uses multiple conditions. Previously, we tested conflicting status fields (hostname), but don't have a test for conflicting status. This test add logic that exercises new logic in the router for the Upgrade Validation plugin.
gcs278
force-pushed
the
OCPBUGS-26498-upgradeable-status-4.15
branch
from
76880df to
6132a62
Compare
|
Fabulous instructions. I created a branch, applied your steps, and see zero differences between this PR and my ephemeral branch. /lgtm |
|
Now that openshift/router#585 has merged, this is no longer WIP. |
gcs278
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Unrelated |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/retest-required |
|
/approve |
|
|
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/retest |
|
/lgtm |
|
@xueqzhan thanks for the LGTM! I actually need approve and backport-risk-assessed. Are you able to do that? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, gcs278, Miciah, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Ah thanks @xueqzhan, sorry the for confusion. I suppose this repo has |
deads2k
added
the
backport-risk-assessed
openshift-ci
bot
assigned
adambkaplan,
dgoodwin,
gangwgr,
jadhaj,
jitendar-singh,
kasturinarra,
pamoedom and
prietyc123
deads2k
added
the
cherry-pick-approved
|
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@gcs278: Jira Issue OCPBUGS-28928: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-28928 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202406100906.p0.gc13a01e.assembly.stream.el8 for distgit openshift-enterprise-tests. |
|
Fix included in accepted release 4.15.0-0.nightly-2024-06-12-223752 |
…ble-status-4.15 OCPBUGS-28928: Add test for UpgradeValidation contention
16 participants
Manual cherry-pick of #28710
Add "The HAProxy router converges when multiple routers are writing conflicting upgrade validation status" test which validates router converge when writing conflicting status in a scenario that uses multiple conditions.
Previously, we tested conflicting status fields (hostname), but don't have a test for conflicting status. This test add logic that exercises new logic in the router for the Upgrade Validation plugin.
Also, this updates all of the router stress.go status tests write watch logic to use an informer, which allows for comparison of the old and new route objects along with the ability to start the informer in a separate go routine.
HOW I CREATED THIS PR: