IR-412: IBMCloud: Add support for endpoint overrides

[cjschaef]

Add support to override IBM Cloud Service endpoints, when provided.

Related: https://issues.redhat.com/browse/IR-412

[openshift-ci-robot]

@cjschaef: This pull request references IR-412 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Add support to override IBM Cloud Service endpoints, when provided.

Related: https://issues.redhat.com/browse/IR-412

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[flavianmissi]

/retest

[flavianmissi]

Nice work @cjschaef. I have no objections towards merging this. Do you have a plan in regards to px, docs and qe approval?
/test e2e-ibm-ovn

[openshift-ci]

@flavianmissi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test e2e-aws-operator
• /test e2e-aws-ovn
• /test e2e-aws-ovn-image-registry
• /test e2e-aws-ovn-upgrade
• /test e2e-hypershift
• /test e2e-hypershift-conformance
• /test e2e-vsphere-operator
• /test images
• /test unit
• /test verify

The following commands are available to trigger optional jobs:

• /test e2e-azure-manual-oidc
• /test e2e-azure-operator
• /test e2e-azure-ovn
• /test e2e-gcp-operator
• /test e2e-gcp-ovn
• /test e2e-openstack
• /test e2e-vsphere

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-operator
• pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-ovn
• pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-ovn-image-registry
• pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-ovn-upgrade
• pull-ci-openshift-cluster-image-registry-operator-master-e2e-hypershift
• pull-ci-openshift-cluster-image-registry-operator-master-e2e-hypershift-conformance
• pull-ci-openshift-cluster-image-registry-operator-master-images
• pull-ci-openshift-cluster-image-registry-operator-master-unit
• pull-ci-openshift-cluster-image-registry-operator-master-verify

Details

In response to this:

Nice work @cjschaef. I have no objections towards merging this. Do you have a plan in regards to px, docs and qe approval?
/test e2e-ibm-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[flavianmissi]

/test e2e-aws-operator

[cjschaef]

@flavianmissi We will be providing some documentation for IBM Cloud Restricted Network setup and configuration. At this time, these code changes are dependent on the installer, the CCM, and MAPI, to even get to a point to exercise this code (I've best testing in a Disconnected environment). But there are still some items I am working on yet related to the installer.

I will want to work with QE on whether an environment can be configured to test IBM Cloud Disconnected, as I know it requires a good number of user configuration steps and resource setup at this time. If I am able, I'd like to also investigate extending the ibmcos_test.go tests, in case I can add something there. If I can do that before 4.15 FF.

[flavianmissi]

Thanks for clarifying @cjschaef.
@wewang58 is our QE currently, she might be able to help you out with a cluster.
Maybe you already know this but you can reach the image registry team in Red Hat internal Slack at #forum-ocp-imageregistry if you need faster response.
Also recall that TRT is blocking non-critical merges for the next two weeks due to shift week and US holidays, this might affect your plans for 4.15 (it surely has affected mine).

[cjschaef]

@flavianmissi Okay, thanks for the details.

I have completed testing of these changes in my Disconnected (air-gapped) environment, using all of the changes with installer, CCM, and MAPI, to validate this Operator came up successfully and was using the provided overrides, and was able to communicate with the IBM Cloud Service endpoints (overrides), using IBM Cloud VPC VPE Gateways.

I'll have to guide @wewang58 on the complete setup of this Disconnected environment, and the current dependencies, and limitations (other ClusterOperators require similar changes, etc.), given the vast number of changes across components to test this code, and other components to get a happy IPI cluster (Storage, etc.), if we are going to need that kind of confirmation. It is certainly non-trivial by default, not including the requirement of these other dependent PR's.

Otherwise, not breaking existing functionality, for Public, Private, and BYON IBM Cloud IPI clusters would be good confirmation.

Okay, I believe we will be working on getting approval for these feature changes for the TRT.

[cjschaef]

openshift/api#1657 has merged, I will attempt to update the api go dep and update the ServiceName's to use these new enum's.

I pulled in the latest api to use IBMCloudServiceName's.

[cjschaef]

/retest

[flavianmissi]

Sounds like a plan @cjschaef.
I'll leave it to you to sync with Wen to get QE approval. Do let me know if I can help.

[cjschaef]

I'll see about rebasing and go mod changes.

Updated

[flavianmissi]

/lgtm
it looks like QE needs some help testing this.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjschaef, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sferich888]

/label px-approved

[stevsmit]

/label docs-approved

[wewang58]

Now installer qe team is trying to provide a private cluster which support for endpoint overrides, they met some issues need time to resolve.

[wewang58]

Tested in version: 4.15.0-0.ci.test-2023-12-08-081140-ci-ln-1sdsy7t-latest, cos endpoint is override, thanks @jianlinliu provides the cluster
/label qe-approved

[openshift-ci-robot]

@cjschaef: This pull request references IR-412 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Add support to override IBM Cloud Service endpoints, when provided.

Related: https://issues.redhat.com/browse/IR-412

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 59f66cd and 2 for PR HEAD 06da1d4 in total

[flavianmissi]

/retest

[flavianmissi]

/retest

[jeffnowicki]

/retest-required

[jeffnowicki]

/test e2e-hypershift-conformance

[cjschaef]

It looks like the e2e-hypershift-conformance failures are consistent across other PR's as well.
Not sure if that issue is being addressed, or whether we can ignore the failure, given the code changes aren't involved, as other PR's suffer the same failure.

[flavianmissi]

Yep it does happen everywhere. Let's retry one last time before I make some noise.
/retest

[flavianmissi]

last error looks different than the previous.
/retest

[jeffnowicki]

@flavianmissi the e2e-hypershift-conformance test is failing in other PRs as well. Are we certain there isn't an issue with the test itself? The code in this PR doesn't have any hypershift relationship.

[flavianmissi]

oh yes there certainly is an issue with the these tests - I was just hoping they had fixed it between today and yesterday but it doesn't look like it. I'll have to find out how to skip them, will write back here when I know more.

[flavianmissi]

/override ci/prow/e2e-hypershift-conformance

[openshift-ci]

@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-hypershift-conformance

Details

In response to this:

/override ci/prow/e2e-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@cjschaef: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.16.0-202312121444.p0.g08206ec.assembly.stream for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

[jianlinliu]

@cjschaef we need to backport this PR into 4.15 branch, right?

[cjschaef]

@jianlinliu It would appear so. Let me try to get that done.

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@cjschaef: new pull request created: #984

Details

In response to this:

@jianlinliu It would appear so. Let me try to get that done.

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.