Skip to content

Comments

[release-4.15] OCPBUGS-26063: IBMCloud - Add support for endpoint overrides#984

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-955-to-release-4.15
Jan 4, 2024
Merged

[release-4.15] OCPBUGS-26063: IBMCloud - Add support for endpoint overrides#984
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-955-to-release-4.15

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #955

/assign cjschaef

Add support to override IBM Cloud Service endpoints, when provided.

Related: https://issues.redhat.com/browse/IR-412
Update the IBM golang dependency packages and openshift/api
for IBMCloudServiceName's.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 3, 2024

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: IR-412

Details

In response to this:

This is an automated cherry-pick of #955

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: cjschaef.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

This is an automated cherry-pick of #955

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dmage and flavianmissi January 3, 2024 16:49
@cjschaef
Copy link
Member

cjschaef commented Jan 3, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffnowicki
Copy link

/assign @flavianmissi

@wewang58
Copy link

wewang58 commented Jan 4, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 4, 2024
@flavianmissi
Copy link
Member

I'm giving the required labels but you need to create a bug for this so we can get the bot to label the PR with jira/valid-bug. Left instructions on Slack.
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 4, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@jianlinliu
Copy link

/retitle [release-4.15] OCPBUGS-26063: IBMCloud - Add support for endpoint overrides

@openshift-ci openshift-ci bot changed the title [release-4.15] IR-412: IBMCloud: Add support for endpoint overrides [release-4.15] OCPBUGS-26063: IBMCloud - Add support for endpoint overrides Jan 4, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 4, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-26063, which is invalid:

  • expected Jira Issue OCPBUGS-26063 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #955

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianlinliu
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: This pull request references Jira Issue OCPBUGS-26063, which is invalid:

  • expected Jira Issue OCPBUGS-26063 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianlinliu
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: This pull request references Jira Issue OCPBUGS-26063, which is invalid:

  • expected dependent Jira Issue OCPBUGS-26064 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianlinliu
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 4, 2024
@openshift-ci-robot
Copy link
Contributor

@jianlinliu: This pull request references Jira Issue OCPBUGS-26063, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26064 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-26064 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xiuwang January 4, 2024 12:33
@openshift-merge-bot openshift-merge-bot bot merged commit 0fcdb4f into openshift:release-4.15 Jan 4, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-26063: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26063 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #955

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.15.0-202401041312.p0.g0fcdb4f.assembly.stream for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants