Skip to content

Comments

OCPCLOUD-2183: Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.28 (1584359) into master#47

Merged
openshift-merge-bot[bot] merged 58 commits intoopenshift:masterfrom
openshift-cloud-team:rebase-bot-master
Nov 10, 2023
Merged

OCPCLOUD-2183: Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.28 (1584359) into master#47
openshift-merge-bot[bot] merged 58 commits intoopenshift:masterfrom
openshift-cloud-team:rebase-bot-master

Conversation

@cloud-team-rebase-bot
Copy link

@cloud-team-rebase-bot cloud-team-rebase-bot bot commented Feb 16, 2023

No description provided.

@openshift-ci openshift-ci bot requested review from damdo and lobziik February 16, 2023 12:14
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2023

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2023
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (e2eae24) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (7a793d5) into master Feb 20, 2023
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (7a793d5) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (4ab7fbc) into master Feb 23, 2023
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (4ab7fbc) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (a92ef79) into master Feb 27, 2023
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (a92ef79) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (fb9a791) into master Mar 2, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from 664ed2e to fb8514a Compare March 2, 2023 12:16
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (fb9a791) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (0d61a94) into master Mar 6, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from fb8514a to 7b9e0d0 Compare March 6, 2023 12:22
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (0d61a94) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (bcc222d) into master Mar 9, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from 7b9e0d0 to 65bb16c Compare March 9, 2023 12:23
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (bcc222d) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (f885826) into master Mar 13, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from 65bb16c to 21649cb Compare March 13, 2023 12:16
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (f885826) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (6812454) into master Mar 16, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from 21649cb to 2b9fdad Compare March 16, 2023 12:22
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (6812454) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (9f26c1b) into master Mar 20, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch 2 times, most recently from 31f93a9 to 866b968 Compare March 23, 2023 12:16
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (9f26c1b) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (e955cfa) into master Mar 27, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from 866b968 to f27a0aa Compare March 27, 2023 08:23
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (e955cfa) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (10ec263) into master Mar 30, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from f27a0aa to 7e390d2 Compare March 30, 2023 12:22
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (10ec263) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (83a28c5) into master Apr 3, 2023
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from 7e390d2 to 227488c Compare April 3, 2023 12:14
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (83a28c5) into master Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.26 (0dcb003) into master Apr 6, 2023
@cjschaef
Copy link
Member

cjschaef commented Nov 2, 2023

Investigating the failures of e2e-ibmcloud, it doesn't appear they are related to changes to the CCM.
The previous failure, test cases primarily failed due to the server is currently unable to handle the request, which I suspect may be due to Infrastructure (LB) related issues.

The latest failure has some of these causes as well, but it appears a number of test cases failed due to issues with openshift-multus resources, which again are not related to these CCM chanages.

I think we can ignore these test failures from e2e-ibmcloud at this time.

@iksrochpub
Automated repo sync 20231106
f709a79 
Update module github.com/IBM/platform-services-go-sdk to v0.53.0 (#3803)
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title OCPCLOUD-2183: Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.28 (59c1d86) into master OCPCLOUD-2183: Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.28 (f709a79) into master Nov 6, 2023
@cjschaef
Copy link
Member

cjschaef commented Nov 6, 2023

/retest

iksrochpub and others added 10 commits November 7, 2023 06:00
@iksrochpub
Automated repo sync 20231107
c3f6e8f 
Update module github.com/spf13/cobra to v1.8.0 (#3810)
@iksrochpub
Automated repo sync 20231109
1584359 
Update module github.com/IBM/platform-services-go-sdk to v0.53.1 (#3822)
merge upstream/release-1.28 into master
afe9f79
@Fedosin
UPSTREAM: <carry>: Add OWNERS
78997ef 
(cherry picked from commit f210a1d)
@Fedosin
UPSTREAM: <carry>: Add a Dockerfile that compatible with OpenShift
b994c55
UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images t…
6464c1f 
…o be consistent with ART

Squashed:
fab1cc0
396acfb
672425c

UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/61541c1c730569d20db98c885bb07d7ee96e648c/images/ose-ibm-cloud-controller-manager.yml

UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/e18d948b6ec9fc99c368102cffc1eea0c01f5765/images/ose-ibm-cloud-controller-manager.yml

UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/7575d251c23bb6784e1f762f3566c2770b051097/images/ose-ibm-cloud-controller-manager.yml
@JoelSpeed
UPSTREAM: <carry>: Sync OWNERS file
f0f7fb1 
UPSTREAM: <carry>: Sync OWNERS file
UPSTREAM: <carry>: Updating ose-ibm-cloud-controller-manager images t…
78daae8 
…o be consistent with ART

Reconciling with https://github.com/openshift/ocp-build-data/tree/da6a5af1fa96762cc8410f09fc28c0457280f59a/images/ose-ibm-cloud-controller-manager.yml
@RadekManak
UPSTREAM: <carry>: Sync OWNERS file
b81d21f
UPSTREAM: <carry>: Updating and vendoring go modules after an upstrea…
bb19c81 
…m rebase
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title OCPCLOUD-2183: Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.28 (f709a79) into master OCPCLOUD-2183: Merge https://github.com/IBM-Cloud/cloud-provider-ibm:release-1.28 (1584359) into master Nov 9, 2023
@cjschaef cjschaef mentioned this pull request Nov 10, 2023
Merged
@JoelSpeed
Copy link

JoelSpeed commented Nov 10, 2023

Would like to run one more time and see if we get a different result before committing to this merge,
/test e2e-ibmcloud

@cjschaef
Copy link
Member

cjschaef commented Nov 10, 2023

These new results are much more inline with what is being seen in other repos/PR's
image

I am very confident now that these changes are safe to merge.

@JoelSpeed
Copy link

JoelSpeed commented Nov 10, 2023

/approve
/lgtm
/override ci/prow/e2e-ibmcloud

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2023

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-ibmcloud

Details

In response to this:

/approve
/lgtm
/override ci/prow/e2e-ibmcloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2023

@cloud-team-rebase-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 8f1009c into openshift:master Nov 10, 2023
@openshift-bot
Copy link

openshift-bot commented Nov 13, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibm-cloud-controller-manager-container-v4.15.0-202311131732.p0.g8f1009c.assembly.stream for distgit ose-ibm-cloud-controller-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@RadekManak @damdo @elmiko @cjschaef @openshift-ci-robot @JoelSpeed @openshift-bot @iksrochpub @Fedosin