[release-4.3] Bug 1799447: Swiftless OpenStack #453
Conversation
To allow us to define a rollout strategy for the image registry deployment, we create an additional parameter in ImageRegistrySpec.
This parameter allows to define rollout strategy for the image registry deployment.
This patch adds a function that checks if Swift service is enabled. To do so it reuses the existing getSwiftClient function, that has this check.
This commit allows to use RWO PVC backend for OpenStack if Swift is not available.
|
@Fedosin: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
openshift/api should be updated as well. Ideally #424 should be merged and we should use types from openshift/api. |
|
@Fedosin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@dmage I worry that landing an openshift/api change may be exceptionally difficult with our patch management process. IMO adding CRD definitions for the image registry is lower priority than getting this feature back-ported (this is blocking several OpenStack customers). |
|
@adambkaplan if it were 4.5 -> 4.4 backport, it would be the only way to do it. At least there should be a (perhaps open) PR in openshift/api before we merge this. And as a follow-up we should update (re-vendor) CRD yaml in this repo. |
|
@dmage Per discussion in scrum on Thursday, I believe we agreed on the following order of operations:
|
dmage
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Fedosin: This pull request references Bugzilla bug 1799447, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Fedosin per discussion on the Group D arch call today, we won't backport this feature unless it is directly related to the IPv6 initiatives. Our QE does not have the bandwidth to do full feature testing with every z-stream release, so only bugs with automatic test coverage will be merged. I apologize if this has led to "wasted" effort on your behalf. |
|
/close |
|
@adambkaplan: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This patch is a backport of next PRs:
#428
#439
#441