Skip to content

Bug 1785302: Using types from openshift/api repository. #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Feb 20, 2020
Merged

Bug 1785302: Using types from openshift/api repository. #424

openshift-merge-robot merged 3 commits into from
Feb 20, 2020

Conversation

@ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Jan 3, 2020 •
edited
Loading

With this PR we migrate our data types to openshift/api and import them here as it is done on our current master branch. Unfortunately due to conflicts it become easier to just create a new branch/PR instead of cherry picking it from the original version.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 3, 2020

@ricardomaraschini: This pull request references Bugzilla bug 1785302, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

WIP - Bug 1785302: Using types from openshift/api repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 3, 2020
@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Jan 3, 2020

/test e2e-aws-operator

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Jan 13, 2020

/retest

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Jan 14, 2020

/test e2e-aws-operator

@dmage dmage mentioned this pull request Jan 30, 2020
Closed
@adambkaplan
Copy link
Contributor

adambkaplan commented Jan 30, 2020

/bugzilla refresh

@ricardomaraschini is this still work in progress?

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2020

@adambkaplan: This pull request references Bugzilla bug 1785302, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

@ricardomaraschini is this still work in progress?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Contributor

dmage commented Feb 6, 2020

/retest

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Feb 6, 2020

will it blend this time?

@dmage
Copy link
Contributor

dmage commented Feb 6, 2020

@ricardomaraschini can you remove WIP from the title? or is there anything else to do?

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Feb 7, 2020

OMG @dmage ! It is passing! Thank you very much!

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2020

@ricardomaraschini: This pull request references Bugzilla bug 1785302, which is valid.

Details

In response to this:

WIP - Bug 1785302: Using types from openshift/api repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini ricardomaraschini changed the title WIP - Bug 1785302: Using types from openshift/api repository. Bug 1785302: Using types from openshift/api repository. Feb 7, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2020
@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Feb 7, 2020

/assign @dmage

@dmage
Copy link
Contributor

dmage commented Feb 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 19, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c78a0b6 into openshift:release-4.3 Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

@ricardomaraschini: All pull requests linked via external trackers have merged. Bugzilla bug 1785302 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1785302: Using types from openshift/api repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@dmage dmage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ricardomaraschini @openshift-ci-robot @adambkaplan @dmage @openshift-bot @bparees @openshift-merge-robot