Skip to content

Swiftless ShiftStack installation - OSDOCS923 #20420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxwelldb merged 1 commit into from
Apr 14, 2020
Merged

Swiftless ShiftStack installation - OSDOCS923 #20420

maxwelldb merged 1 commit into from
Apr 14, 2020

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Mar 11, 2020 •
edited
Loading

For https://issues.redhat.com/browse/OSDOCS-923

  • Dev review
  • QE
  • Peer review

@maxwelldb maxwelldb added this to the Future Release milestone Mar 11, 2020
@maxwelldb maxwelldb self-assigned this Mar 11, 2020
@maxwelldb maxwelldb added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Mar 17, 2020

The preview will be available shortly at:

racedo
racedo reviewed Mar 17, 2020
View reviewed changes
Copy link

@racedo racedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links for Object Storage / Swift should be to OSP docs. We support Object with Ceph Rados GW and with Swift:

https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.0/html-single/deploying_an_overcloud_with_containerized_red_hat_ceph/index#ceph-rgw

https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.0/html-single/storage_guide/index#ch-manage-containers

Please, use these links instead of docs.openstack.org's

racedo
racedo reviewed Mar 17, 2020
View reviewed changes
Copy link

@racedo racedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With regards to preferred technology for the registry that's object storage. We should explain/remind users about this in this section, you can also point them to this explanation: https://docs.openshift.com/container-platform/4.3/scalability_and_performance/optimizing-storage.html#registry

@maxwelldb maxwelldb force-pushed the shiftstack-swiftless-osdocs922 branch 2 times, most recently from 1b3d3d4 to 4b55031 Compare March 18, 2020 20:26
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 18, 2020

Updating first two links.

As a quirk of Red Hat's modular documentation scheme, we're unable to link from one OCP docs page to another. I'll see if there's a way to include that information in a way that makes sense within this module.

@maxwelldb maxwelldb force-pushed the shiftstack-swiftless-osdocs922 branch from 2d80b76 to ea0a9b2 Compare March 18, 2020 21:19
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 18, 2020

Any feedback on ea0a9b2, @racedo ?

mandre
mandre reviewed Mar 27, 2020
View reviewed changes
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 27, 2020 via email

@mandre mandre mentioned this pull request Mar 27, 2020
Merged
10 tasks
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Mar 27, 2020

@mandre Not sure when the preview will finish building, but you can see the latest changes as 76cf298 immediately, at least. Let me know what you think.

mandre
mandre reviewed Mar 30, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2020
Fedosin
Fedosin reviewed Apr 8, 2020
View reviewed changes
@maxwelldb maxwelldb requested a review from a user April 13, 2020 23:11
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

Or @gpei and @morenod, if either of you have bandwidth for this PR, I'd much appreciate a 👍 / 👎

@morenod
Copy link

morenod commented Apr 14, 2020

/lgtml

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

@morenod Thanks!

@maxwelldb maxwelldb removed the request for review from a user April 14, 2020 14:30
@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 14, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

@mburke5678 Thanks! Thoughts on c62b793?

mburke5678
mburke5678 reviewed Apr 14, 2020
View reviewed changes
@mburke5678
Copy link
Contributor

mburke5678 commented Apr 14, 2020

@maxwelldb One last nit and LGTM

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

@mburke5678 Periods added.

@maxwelldb maxwelldb force-pushed the shiftstack-swiftless-osdocs922 branch from 567a7ed to f6906db Compare April 14, 2020 15:47
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

(And commits squashed.)

@maxwelldb maxwelldb requested a review from mburke5678 April 14, 2020 15:49
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 14, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

@mburke5678 Thanks!

@maxwelldb maxwelldb merged commit 859c026 into openshift:master Apr 14, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 14, 2020

@maxwelldb: new pull request created: #21143

Details

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb maxwelldb deleted the shiftstack-swiftless-osdocs922 branch April 14, 2020 15:53
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2020
Merged
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Apr 14, 2020

Not backported to 4.3 as per openshift/cluster-image-registry-operator#453 (comment)

@maxwelldb maxwelldb mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 approved these changes

+3 more reviewers

@mandre mandre mandre left review comments

@racedo racedo racedo left review comments

@Fedosin Fedosin Fedosin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@maxwelldb maxwelldb

Labels

branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.4 GA

Development

Successfully merging this pull request may close these issues.

10 participants

@maxwelldb @openshift-docs-preview-bot @morenod @mburke5678 @openshift-cherrypick-robot @mandre @racedo @Fedosin @vikram-redhat @openshift-ci-robot