Skip to content

Bug 1915473: Annotate manifests for single-node-developer cluster profile #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 28, 2021
Merged

Bug 1915473: Annotate manifests for single-node-developer cluster profile #216

openshift-merge-robot merged 2 commits into from
Mar 28, 2021

Conversation

@cfergeau
Copy link
Contributor

@cfergeau cfergeau commented Nov 26, 2020

This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-dns-operator CRD
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.

@cfergeau cfergeau force-pushed the single-node-dev branch 2 times, most recently from 68d3a9c to d55402f Compare November 30, 2020 14:22
@cfergeau
Copy link
Contributor Author

cfergeau commented Dec 2, 2020

/retest

@cfergeau cfergeau changed the title Annotate manifests for single-node-developer cluster profile Bug 1915473: Annotate manifests for single-node-developer cluster profile Jan 12, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2021

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 13, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2021

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Bump github.com/openshift/api
8e21906 
The newly added 'include.release.openshift.io/single-node-developer: true'
annotation will be needed in the next commit
@cfergeau
Annotate manifests for single-node-developer cluster profile
c728a0c 
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-dns-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.
@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 13, 2021

Could this get a review?

@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 14, 2021

/retest

1 similar comment
@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 14, 2021

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 15, 2021
Merged
@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 15, 2021

/retest

This was referenced Jan 15, 2021
Merged
Merged
Merged
Merged
@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 19, 2021

@danehans @candita could you take a look?

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 20, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 19, 2021
Merged
5 tasks
@cfergeau
Copy link
Contributor Author

cfergeau commented Mar 19, 2021

How can I get a review on this? @Miciah @sgreene570 ?

@praveenkumar
Copy link

praveenkumar commented Mar 19, 2021

Can some look into this with higher priority because it is breaking the CI in cluster is provision with single-node-developer profile as this operator is excluded and there is no dns for cluster.

praveenkumar added a commit to praveenkumar/snc that referenced this pull request Mar 19, 2021
@praveenkumar
Remove OPENSHIFT_INSTALL_EXPERIMENTAL_CLUSTER_PROFILE env for installer
6e91fab 
single-node-developer profile is not part of some of the operators and
we recently noticed that it is causing the issue for dns operator where
openshift/cluster-dns-operator#216 is still not
merged and because of that the dns operator manifest doesn't part of
CVO.

This caused issue for upstream CI and really became hard to debug so
this patch will make sure we don't use any profile and go with default.

- BZ https://bugzilla.redhat.com/show_bug.cgi?id=1940309
@praveenkumar praveenkumar mentioned this pull request Mar 19, 2021
Merged
praveenkumar added a commit to crc-org/snc that referenced this pull request Mar 19, 2021
@praveenkumar
Remove OPENSHIFT_INSTALL_EXPERIMENTAL_CLUSTER_PROFILE env for installer
c4abe77 
single-node-developer profile is not part of some of the operators and
we recently noticed that it is causing the issue for dns operator where
openshift/cluster-dns-operator#216 is still not
merged and because of that the dns operator manifest doesn't part of
CVO.

This caused issue for upstream CI and really became hard to debug so
this patch will make sure we don't use any profile and go with default.

- BZ https://bugzilla.redhat.com/show_bug.cgi?id=1940309
@sgreene570
Copy link
Contributor

sgreene570 commented Mar 19, 2021

Sorry for the delay!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@praveenkumar
Copy link

praveenkumar commented Mar 20, 2021

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f036ecf into openshift:master Mar 28, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 28, 2021

@cfergeau: All pull requests linked via external trackers have merged:

Bugzilla bug 1915473 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candita candita Awaiting requested review from candita

@danehans danehans Awaiting requested review from danehans

Assignees

@sgreene570 sgreene570

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cfergeau @openshift-ci-robot @praveenkumar @sgreene570 @openshift-bot @openshift-merge-robot