Bug 1915473: Annotate manifests for single-node-developer cluster profile #774
Conversation
|
/retest |
This partially implements phase 1 of https://github.com/openshift/enhancements#482 and does not change behavior. Initially, all machine-api-operator manifests are included in the single-node-developer cluster profile. Follow-on PRs may exclude any of these that are not needed in the profile.
cfergeau
force-pushed
the
single-node-developer
branch
from
517905e to
eb7fd7f
Compare
|
It was my understanding the Machine API was entirely unneeded in the proposal? I think we should be tackling this the other way round and marking everything here as |
|
We indeed had a similar discussion while working on the patches :) As we don't know whether anything requires the machine api during install/bootstrap, we prefer to be on the safe side, and start by enabling everything, and once we have something that works, remove what we don't need. |
Nothing needs this during install/bootstrap, that discussion has been had already I thought, I had to ack some spreadsheet about that anyway 😅 Perhaps the installation process may differ for SNO?
Ok, I can appreciate that |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
@cfergeau: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
cfergeau
changed the title
openshift-ci-robot
added
bugzilla/severity-unspecified
|
@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh |
openshift-ci-robot
removed
the
bugzilla/severity-unspecified
|
@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-medium
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cfergeau: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cfergeau: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1915473 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all machine-api-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.