Skip to content

Bug 1915473: Annotate manifests for single-node-developer cluster profile #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 19, 2021
Merged

Bug 1915473: Annotate manifests for single-node-developer cluster profile #1886

openshift-merge-robot merged 1 commit into from
Feb 19, 2021

Conversation

@cfergeau
Copy link
Contributor

@cfergeau cfergeau commented Dec 3, 2020

This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2020
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 3, 2020

Hi @cfergeau. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member

dinhxuanvu commented Dec 4, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2020
@openshift-merge-robot
Copy link
Collaborator

openshift-merge-robot commented Dec 4, 2020

@cfergeau: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-upgrade 2ed2e91 link /test e2e-upgrade
ci/prow/e2e-aws-olm 2ed2e91 link /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 24, 2020
@cfergeau cfergeau force-pushed the single-node-developer branch from 2ed2e91 to 0a92ca4 Compare January 6, 2021 15:26
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2021
@cfergeau cfergeau changed the title Annotate manifests for single-node-developer cluster profile Bug 1915473: Annotate manifests for single-node-developer cluster profile Jan 12, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 12, 2021
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 12, 2021

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 13, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jan 13, 2021
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 13, 2021

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 13, 2021
@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 13, 2021

/retest

@cfergeau
Annotate manifests for single-node-developer cluster profile
f6221e1 
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.

This commit uses 'make release' to update /manifests with single node
developer cluster profile annotation
@cfergeau cfergeau force-pushed the single-node-developer branch from 0a92ca4 to f6221e1 Compare January 19, 2021 09:34
@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 20, 2021

/retest

@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 20, 2021

CI is green now, can this get a review?

@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 25, 2021

CI is green now, can this get a review?

@dinhxuanvu @hasbro17 ?

dinhxuanvu
dinhxuanvu approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2021
@cfergeau
Copy link
Contributor Author

cfergeau commented Feb 17, 2021

/assign @kevinrizza

@ecordell
Copy link
Member

ecordell commented Feb 17, 2021

/approve

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@dinhxuanvu
Copy link
Member

dinhxuanvu commented Feb 17, 2021

/test unit

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 034b400 into operator-framework:master Feb 19, 2021
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 19, 2021

@cfergeau: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1915473 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@kevinrizza kevinrizza

@dinhxuanvu dinhxuanvu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cfergeau @openshift-ci-robot @dinhxuanvu @openshift-merge-robot @ecordell @openshift-bot @kevinrizza