need to store the passed value to the apply cache for later compariso…#1294
need to store the passed value to the apply cache for later compariso…#1294openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
…n even if we mutated it for storage
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm Have been testing this with the csi snapshot operator and it seems to produce a stable operator, no repeated events, and it will apply the changes again if the spec ends up not matching, LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…n even if we mutated it for storage
separately, we could build the mimicDefaulting logic like we did for CRDs.