Skip to content

need to store the passed value to the apply cache for later compariso…#1294

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:store
Jan 21, 2022
Merged

need to store the passed value to the apply cache for later compariso…#1294
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:store

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 21, 2022

…n even if we mutated it for storage

separately, we could build the mimicDefaulting logic like we did for CRDs.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh January 21, 2022 15:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

Have been testing this with the csi snapshot operator and it seems to produce a stable operator, no repeated events, and it will apply the changes again if the spec ends up not matching, LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments