Copy manifests from openshift/api to builder#102
Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom Oct 18, 2019
Merged
Copy manifests from openshift/api to builder#102openshift-merge-robot merged 4 commits intoopenshift:masterfrom
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
damemi
force-pushed
the
copy-api-manifests
branch
2 times, most recently
from
6473e52 to
142fa38
Compare
damemi
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
damemi
force-pushed
the
copy-api-manifests
branch
from
1b6ecfe to
f42ef11
Compare
deads2k
reviewed
Oct 16, 2019
deads2k
reviewed
Oct 16, 2019
damemi
force-pushed
the
copy-api-manifests
branch
2 times, most recently
from
e59d5a6 to
b80d8d9
Compare
Contributor
|
/lgtm |
Contributor
|
/retest |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
These manifests have moved to their respective API locations in openshift/api.
damemi
force-pushed
the
copy-api-manifests
branch
from
b80d8d9 to
f1edfbf
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the CRDs which now live in openshift/api (openshift/api#470) and removes those CRDs from this repo, as well as the codegen Makefile targets