OCPBUGS-20213: Add azure cloud config transformer #291
Conversation
This change adds a boolean return value to the GetCloudConfigTransformer function to indicate when a the cloud config ConfigMap should be looked up from the CCO namespace. It is being added so that we can return a config transformer and also be able to lookup the default values from the CCO. This is primarily to address OCPBUGS-20213 which requires an updated config on Azure Stack Hub.
elmiko
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@elmiko: This pull request references Jira Issue OCPBUGS-20213, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
requested review from
odvarkadaniel,
sunzhaohua2 and
vincepri
elmiko
changed the title
|
@elmiko: This pull request references Jira Issue OCPBUGS-20213, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change creates a CloudConfigTransformer for Azure Stack cloud provider. The transformer will unmarshal json from the cloud config into a `Config` struct from the azure cloud provider and then update the the `VMType` field if it is unset. This is being added because Azure has updated the default vm type to value that cannot be added to the basic load balancers which are associated with Azure Stack. The change also adds a test suite to accompany the transformer.
elmiko
force-pushed
the
add-azure-cloud-config-processor
branch
from
4b62cd2 to
2c922b7
Compare
|
updated to address nits |
|
/approve |
|
@JoelSpeed: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@elmiko: Jira Issue OCPBUGS-20213: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20213 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@elmiko: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@JoelSpeed: #291 failed to apply on top of branch "release-4.14": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-10-27-135451 |
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
5 participants
This change creates a CloudConfigTransformer for Azure Stack cloud
provider. The transformer will unmarshal json from the cloud config into
a
Configstruct from the azure cloud provider and then update the theVMTypefield if it is unset. This is being added because Azure hasupdated the default vm type to value that cannot be added to the basic
load balancers which are associated with Azure Stack.
The change also adds a test suite to accompany the transformer.
I've added a dependency on the upstream cloud-provider-azure to get the Config object so that we can do a proper marshal/unmarshal operation in the transformer. This seemed necessary because I observed some odd type conversions that were happening when trying to marshal/unmarshal using
map[string]interface{}types.