Skip to content

[release-4.15] OCPBUGS-30117: manifests-gen: also add CustomNoUpgrade annotation value#166

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-161-to-release-4.15
Apr 11, 2024
Merged

[release-4.15] OCPBUGS-30117: manifests-gen: also add CustomNoUpgrade annotation value#166
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-161-to-release-4.15

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #161

/assign damdo

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29519 has been cloned as Jira Issue OCPBUGS-30117. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-30117: manifests-gen: also add CustomNoUpgrade annotation value

Details

In response to this:

This is an automated cherry-pick of #161

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-29519: manifests-gen: also add CustomNoUpgrade annotation value [release-4.15] OCPBUGS-30117: manifests-gen: also add CustomNoUpgrade annotation value Mar 1, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 1, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-30117, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29519 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29519 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #161

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 1, 2024
@openshift-ci openshift-ci bot requested review from elmiko, nrb and sunzhaohua2 March 1, 2024 10:14
@damdo
Copy link
Member

damdo commented Mar 18, 2024

/retest

1 similar comment
@damdo
Copy link
Member

damdo commented Mar 20, 2024

/retest

@JoelSpeed
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 20, 2024
@nrb
Copy link
Contributor

nrb commented Mar 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@damdo
Copy link
Member

damdo commented Mar 22, 2024

This change doesn't affect payload, and e2e issues are unrelated.
/override ci/prow/e2e-aws-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-ovn-serial

Details

In response to this:

This change doesn't affect payload, and e2e issues are unrelated.
/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member

damdo commented Apr 10, 2024

/assign @sunzhaohua2

@damdo
Copy link
Member

damdo commented Apr 10, 2024

/assign @miyadav

@sunzhaohua2
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 11, 2024
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0e5dbd0 into openshift:release-4.15 Apr 11, 2024
@openshift-bot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30117: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30117 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #161

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-capi-operator-container-v4.15.0-202404120437.p0.g0e5dbd0.assembly.stream.el9 for distgit ose-cluster-capi-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-04-16-070254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments