Skip to content

[release-4.15] OCPBUGS-30117: manifests: Add in CustomNoUpgrade#206

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
damdo:release-4.15-add-in-customnoupgrade
May 13, 2024
Merged

[release-4.15] OCPBUGS-30117: manifests: Add in CustomNoUpgrade#206
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
damdo:release-4.15-add-in-customnoupgrade

Conversation

@damdo
Copy link
Member

@damdo damdo commented May 8, 2024

  • Bump the manifests-gen tool for achieving the below
  • Reruns manifests-gen to have CVO apply CAPI manifests also in CustomNoUpgrade

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2024
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-30117, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-29519 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29519 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @miyadav

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

  • Bump the manifests-gen tool for achieving the below
  • Reruns manifests-gen to have CVO apply CAPI manifests also in CustomNoUpgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 8, 2024
@openshift-ci openshift-ci bot requested review from RadekManak, miyadav and racheljpg May 8, 2024 14:12
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@JoelSpeed
Copy link

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 8, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@damdo
Copy link
Member Author

damdo commented May 8, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 8, 2024

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sunzhaohua2
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2053e13 into openshift:release-4.15 May 13, 2024
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-30117: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30117 has been moved to the MODIFIED state.

Details

In response to this:

  • Bump the manifests-gen tool for achieving the below
  • Reruns manifests-gen to have CVO apply CAPI manifests also in CustomNoUpgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-api-container-v4.15.0-202405130639.p0.g2053e13.assembly.stream.el9 for distgit ose-cluster-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments