Skip to content

[release-4.15] OCPBUGS-30117: manifests: Add in CustomNoUpgrade#225

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
damdo:release-4.15-add-in-customnoupgrade
May 9, 2024
Merged

[release-4.15] OCPBUGS-30117: manifests: Add in CustomNoUpgrade#225
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
damdo:release-4.15-add-in-customnoupgrade

Conversation

@damdo
Copy link
Member

@damdo damdo commented May 7, 2024

  • Bump the manifests-gen tool for achieving the below
  • Reruns manifests-gen to have CVO apply CAPI manifests also in CustomNoUpgrade

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2024
@openshift-ci-robot
Copy link
Contributor

@damdo: This pull request references Jira Issue OCPBUGS-30117, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

  • Bump the manifests-gen tool for achieving the below
  • Reruns manifests-gen to have CVO apply CAPI manifests also in CustomNoUpgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 7, 2024
@openshift-ci openshift-ci bot requested review from RadekManak and elmiko May 7, 2024 10:55
@damdo
Copy link
Member Author

damdo commented May 7, 2024

Serial failure unrelated and not relevant for this PR:
/override ci/prow/e2e-gcp-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-gcp-serial

Details

In response to this:

Serial failure unrelated and not relevant for this PR:
/override ci/prow/e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-serial 1691780 link true /test e2e-gcp-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented May 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@damdo: This pull request references Jira Issue OCPBUGS-30117, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member Author

damdo commented May 8, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 8, 2024
@openshift-ci-robot
Copy link
Contributor

@damdo: This pull request references Jira Issue OCPBUGS-30117, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-29519 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29519 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @miyadav

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 8, 2024
@openshift-ci openshift-ci bot requested a review from miyadav May 8, 2024 13:50
@damdo
Copy link
Member Author

damdo commented May 8, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 8, 2024
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@JoelSpeed JoelSpeed added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miyadav
Copy link
Member

miyadav commented May 9, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bad5403 into openshift:release-4.15 May 9, 2024
@openshift-ci-robot
Copy link
Contributor

@damdo: Jira Issue OCPBUGS-30117: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-30117 has not been moved to the MODIFIED state.

Details

In response to this:

  • Bump the manifests-gen tool for achieving the below
  • Reruns manifests-gen to have CVO apply CAPI manifests also in CustomNoUpgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-gcp-cluster-api-controllers-container-v4.15.0-202405091343.p0.gbad5403.assembly.stream.el9 for distgit ose-gcp-cluster-api-controllers.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments