Skip to content

[release-4.15] OCPBUGS-29515: manifests-gen: store core capi crds also in their own manifest#160

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-159-to-release-4.15
Feb 27, 2024
Merged

[release-4.15] OCPBUGS-29515: manifests-gen: store core capi crds also in their own manifest#160
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-159-to-release-4.15

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #159

/assign damdo

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly.
We want these to be installed independently from whether the cluster-capi-operator is enabled,
as other Openshift components rely on them.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29476 has been cloned as Jira Issue OCPBUGS-29515. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-29515: manifests-gen: store core capi crds also in their own manifest

Details

In response to this:

This is an automated cherry-pick of #159

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-29476: manifests-gen: store core capi crds also in their own manifest [release-4.15] OCPBUGS-29515: manifests-gen: store core capi crds also in their own manifest Feb 15, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29515, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29476 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #159

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 15, 2024
@openshift-ci openshift-ci bot requested review from RadekManak and damdo February 15, 2024 10:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@damdo
Copy link
Member

damdo commented Feb 15, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@damdo
Copy link
Member

damdo commented Feb 15, 2024

@JoelSpeed can I have backport-risk-assessed? Thx

@JoelSpeed
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 15, 2024
@damdo
Copy link
Member

damdo commented Feb 16, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2024
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-29515, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29476 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29476 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 February 16, 2024 09:08
@damdo
Copy link
Member

damdo commented Feb 16, 2024

cc. @miyadav this is similar to the release 4.16 one. These are only the manifest generator changes.

@miyadav
Copy link
Member

miyadav commented Feb 16, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 16, 2024
@damdo
Copy link
Member

damdo commented Feb 27, 2024

/tide refresh

@sdodson
Copy link
Member

sdodson commented Feb 27, 2024

/label staff-eng-approved

@openshift-ci openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 28229ac into openshift:release-4.15 Feb 27, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29515: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-29515 has not been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #159

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-capi-operator-container-v4.15.0-202402271907.p0.g28229ac.assembly.stream.el9 for distgit ose-cluster-capi-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

Comments