manifests/image-references: add kube-etcd-signer-server #20
Conversation
|
@hexfusion: GitHub didn't allow me to request PR reviews from the following users: abhinavdahiya. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XS
| from: | ||
| kind: DockerImage | ||
| name: docker.io/openshift/origin-cluster-bootstrap:v4.0 | ||
| - name: kube-etcd-signer-server |
There was a problem hiding this comment.
It would be useful to add a comment describing what we use it for. something simple shuld be enough
suggestion:
The `kube-etcd-signer-server` image is required on the bootstrap node to sign certificates for the etcd members to allow bootstrapping of the etcd cluster.
There was a problem hiding this comment.
Yeah, great point updated!
There was a problem hiding this comment.
Where is the connection between cluster-bootstrap aka former bootkube and an etcd image? This looks like a dirty hack.
There was a problem hiding this comment.
The etcd signer is part of bootkube for quorum forming.
Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
force-pushed
the
add_kube-etcd-signer-server
branch
from
15e2158 to
a1f5d26
Compare
|
/lgtm |
smarterclayton
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: hexfusion, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6 participants
ref: openshift/installer#1401
/cc @abhinavdahiya