Skip to content

Conversation

@hexfusion
Copy link
Contributor

This reverts commit a1f5d26.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2019
@wking
Copy link
Member

wking commented Mar 15, 2019

/lgtm

We'll take another run at this next week once we've got an image in https://github.com/openshift/ocp-build-data CC @deads2k, @mfojtik, @sttts, ART builds will be broken until this lands, please take a look.

@openshift-ci-robot
Copy link

@wking: changing LGTM is restricted to assignees, and only openshift/cluster-bootstrap repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

We'll take another run at this next week once we've got an image in https://github.com/openshift/ocp-build-data CC @deads2k, @mfojtik, @sttts, ART builds will be broken until this lands, please take a look.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Mar 15, 2019

CC @smarterclayton too, since it looks like you manually added approved to #20 despite not being an owner ;).

@wking
Copy link
Member

wking commented Mar 15, 2019

e2e-aws:

error: could not run steps: release "release-latest" failed: pod release-latest was already deleted

/retest

@smarterclayton
Copy link

smarterclayton commented Mar 15, 2019

I'm a product owner and I have the GitHub auth to prove it :)

@wking
Copy link
Member

wking commented Mar 16, 2019

All green here. Not having this in is breaking ART builds, right?

@smarterclayton
Copy link

Correct

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2019
@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hexfusion, smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hexfusion, smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants