Skip to content

manifests/image-references: add kube-etcd-signer-server #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Mar 15, 2019
Merged

manifests/image-references: add kube-etcd-signer-server #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions manifests/image-references
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,9 @@ spec:
from:
kind: DockerImage
name: docker.io/openshift/origin-cluster-bootstrap:v4.0
# The `kube-etcd-signer-server` image is required on the bootstrap node to sign certificates
# for the etcd members to allow bootstrapping of the etcd cluster.
- name: kube-etcd-signer-server
Copy link
Contributor

@abhinavdahiya abhinavdahiya Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to add a comment describing what we use it for. something simple shuld be enough
suggestion:

The `kube-etcd-signer-server` image is required on the bootstrap node to sign certificates for the etcd members to allow bootstrapping of the etcd cluster.

Copy link
Contributor Author

@hexfusion hexfusion Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, great point updated!

Copy link
Contributor

@sttts sttts Mar 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the connection between cluster-bootstrap aka former bootkube and an etcd image? This looks like a dirty hack.

Copy link

@smarterclayton smarterclayton Mar 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The etcd signer is part of bootkube for quorum forming.

from:
kind: DockerImage
name: registry.svc.ci.openshift.org/openshift/origin-v4.0:kube-etcd-signer-server