Bug 1827050: Update to use revised ApplyDeployment by marun · Pull Request #272 · openshift/cluster-authentication-operator

marun · 2020-04-16T05:19:09Z

The new method hashes the spec of the deployment which removes the need for forcing rollout.

/cc @deads2k @stlaz

The new method hashes the spec of the deployment which removes the need for considering generation or forcing rollout.

marun · 2020-04-22T18:45:28Z

@stlaz The library-go has merged. Updated and ready for review.

@vareti Adding you as a reviewer since this PR is touching code you added.

/cc @vareti

marun · 2020-04-22T20:16:24Z

/retest

vareti · 2020-04-22T20:25:46Z

pkg/operator2/deployment.go


+	// Ensure a rollout when the bootstrap user goes away
+	if bootstrapUserExists {
+		deployment.Spec.Template.Annotations["operator.openshift.io/bootstrap-user-exists"] = "true"


do you think we should name annotation to imply CAO?

I don't think there's a need for that now, and this is not an API so we can change it anytime in the future.

nit: you could just deployment.Spec.Template.Annotations["operator.openshift.io/bootstrap-user-exists"] = fmt.Sprintf("%v", bootstrapUserExists) to avoid conditions

Why is it desirable to avoid conditions? I think the absence of an annotation is as good a signal as one with a value of "false".

vareti · 2020-04-22T20:26:18Z

one single comment, otherwise /lgtm

vareti · 2020-04-22T20:26:52Z

/lgtm

stlaz · 2020-04-23T07:16:05Z

/approve
looks good

openshift-ci-robot · 2020-04-23T07:16:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, stlaz, vareti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marun · 2020-04-27T17:33:41Z

/retitle Bug 1827050: Update to use revised ApplyDeployment

openshift-ci-robot · 2020-04-27T17:33:59Z

@marun: This pull request references Bugzilla bug 1827050, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1827050: Update to use revised ApplyDeployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-04-27T17:39:44Z

/bugzilla refresh

openshift-ci-robot · 2020-04-27T17:39:50Z

@marun: This pull request references Bugzilla bug 1827050, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-04-27T18:15:39Z

/hold

I will update tomorrow morning.

openshift-ci-robot · 2020-04-28T01:41:36Z

@marun: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-04-28T23:59:38Z

Committed with #282

openshift-ci-robot requested review from deads2k and stlaz April 16, 2020 05:19

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2020

marun mentioned this pull request Apr 16, 2020

Update Apply{DaemonSet,Deployment} to rely on a hash of the spec openshift/library-go#773

Merged

marun added 2 commits April 22, 2020 11:42

bump(library-go)

0e05345

Update to use revised ApplyDeployment

6aca5c5

The new method hashes the spec of the deployment which removes the need for considering generation or forcing rollout.

marun changed the title ~~WIP Update to use revised ApplyDeployment~~ Update to use revised ApplyDeployment Apr 22, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2020

openshift-ci-robot requested a review from vareti April 22, 2020 18:45

vareti reviewed Apr 22, 2020

View reviewed changes

openshift-ci-robot assigned vareti Apr 22, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020

stlaz mentioned this pull request Apr 27, 2020

Bug 1828457: bump(*): vendor update #282

Merged

openshift-ci-robot changed the title ~~Update to use revised ApplyDeployment~~ Bug 1827050: Update to use revised ApplyDeployment Apr 27, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 27, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 27, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2020

marun closed this Apr 28, 2020

marun deleted the cleanup-condition-handling branch April 28, 2020 23:59

openshift-ci-robot mentioned this pull request Apr 29, 2020

Bug 1827050: Update to use revised ApplyDeployment openshift/cluster-openshift-apiserver-operator#354

Merged

This was referenced May 7, 2020

Bug 1827050: Update to use revised ApplyDeployment openshift/console-operator#421

Merged

Bug 1827050: Update to use revised ApplyDeployment openshift/cluster-image-registry-operator#550

Merged

openshift-ci-robot mentioned this pull request May 20, 2020

Bug 1827050: Update to use revised ApplyDeployment openshift/machine-api-operator#589

Merged

Conversation

marun commented Apr 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marun commented Apr 22, 2020

Uh oh!

marun commented Apr 22, 2020

Uh oh!

vareti Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

stlaz Apr 23, 2020

Choose a reason for hiding this comment

Uh oh!

marun Apr 23, 2020

Choose a reason for hiding this comment

Uh oh!

vareti commented Apr 22, 2020

Uh oh!

vareti commented Apr 22, 2020

Uh oh!

stlaz commented Apr 23, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

marun commented Apr 27, 2020

Uh oh!

openshift-ci-robot commented Apr 27, 2020

Uh oh!

marun commented Apr 27, 2020

Uh oh!

openshift-ci-robot commented Apr 27, 2020

Uh oh!

mfojtik commented Apr 27, 2020

Uh oh!

openshift-ci-robot commented Apr 28, 2020

Uh oh!

marun commented Apr 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marun commented Apr 16, 2020 •

edited

Loading