Bug 1827050: Update to use revised ApplyDeployment by marun · Pull Request #421 · openshift/console-operator

marun · 2020-05-03T16:13:15Z

The new method hashes the spec of the deployment which removes the need for forcing rollout.

openshift-ci-robot · 2020-05-03T16:13:21Z

@marun: This pull request references Bugzilla bug 1827050, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1827050: Update to use revised ApplyDeployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen

/approve
/lgtm

Appreciate the bump!

marun · 2020-05-04T16:55:14Z

/hold

There is a bit more cleanup possible, updating shortly.

marun · 2020-05-04T17:08:53Z

/hold cancel

Removed now incorrect comment indicating that ApplyDeployment did not consider the pod template in determining rollout.

Out of curiosity, why are the deployment's annotations mirrored on the pod template?

benjaminapetersen

/lgtm

openshift-bot · 2020-05-04T18:22:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T18:48:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T19:39:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T19:52:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-05-04T20:04:40Z

Out of curiosity, why are the deployment's annotations mirrored on the pod template?

To force a rollout. Changing the deployment annotations doesn't force a rollout, but changing the pod template annotations does.

marun · 2020-05-04T20:21:54Z

Out of curiosity, why are the deployment's annotations mirrored on the pod template?

To force a rollout. Changing the deployment annotations doesn't force a rollout, but changing the pod template annotations does.

Whoops, I should have asked the reverse. Why mirror the pod's annotations on the deployment?

spadgett · 2020-05-04T20:27:00Z

Whoops, I should have asked the reverse. Why mirror the pod's annotations on the deployment?

I suspect at the time the comment was written it was accurate, but that's since been fixed in library-go.

openshift-bot · 2020-05-04T20:44:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T20:59:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T21:50:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T22:02:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T22:15:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T22:29:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T23:07:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-04T23:33:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T00:26:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T00:38:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T00:51:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T01:23:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T01:36:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T02:02:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T02:15:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T02:28:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T02:41:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T02:54:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T03:21:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T03:47:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-05T03:59:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

marun · 2020-05-05T04:04:42Z

/hold

The library-go bump is resulting in test failure due to a metrics registration problem.

This is now handled by library-go's controllercmd framework.

The new method hashes the spec of the deployment which removes the need to explicitly force.

benjaminapetersen · 2020-05-07T15:33:39Z

/lgtm

openshift-ci-robot · 2020-05-07T15:34:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [benjaminapetersen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2020-05-07T15:35:26Z

/hold cancel

openshift-ci-robot · 2020-05-07T17:22:41Z

@marun: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

openshift/cluster-authentication-operator#272 is closed
Bugzilla bug 1827050 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1827050: Update to use revised ApplyDeployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bump(*)

2cffeeb

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 3, 2020

openshift-ci-robot requested review from benjaminapetersen and jhadvig May 3, 2020 16:13

benjaminapetersen approved these changes May 4, 2020

View reviewed changes

openshift-ci-robot assigned benjaminapetersen May 4, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 4, 2020

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels May 4, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2020

benjaminapetersen approved these changes May 4, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020

marun added 2 commits May 5, 2020 07:14

Stop explicitly registering build info metrics

d9a9b51

This is now handled by library-go's controllercmd framework.

Update to use revised ApplyDeployment

b92f7ed

The new method hashes the spec of the deployment which removes the need to explicitly force.

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020

openshift-merge-robot merged commit 684b51d into openshift:master May 7, 2020

Conversation

marun commented May 3, 2020

Uh oh!

openshift-ci-robot commented May 3, 2020

Uh oh!

benjaminapetersen left a comment

Choose a reason for hiding this comment

Uh oh!

marun commented May 4, 2020

Uh oh!

marun commented May 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjaminapetersen left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

spadgett commented May 4, 2020

Uh oh!

marun commented May 4, 2020

Uh oh!

spadgett commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 4, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

openshift-bot commented May 5, 2020

Uh oh!

marun commented May 5, 2020

Uh oh!

benjaminapetersen commented May 7, 2020

Uh oh!

openshift-ci-robot commented May 7, 2020

Uh oh!

spadgett commented May 7, 2020

Uh oh!

marun commented May 4, 2020 •

edited

Loading