Skip to content

Bug 1827050: Update to use revised ApplyDeployment#354

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
marun:apply-deployment
Apr 29, 2020
Merged

Bug 1827050: Update to use revised ApplyDeployment#354
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
marun:apply-deployment

Conversation

@marun
Copy link
Contributor

@marun marun commented Apr 16, 2020 •
edited
Loading

The new method hashes the spec of the deployment which removes the setting an annotation containing the replica count.

/cc @deads2k @stlaz

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2020
@marun marun mentioned this pull request Apr 16, 2020
Merged
@marun marun changed the title WIP Update to use revised ApplyDeployment Update to use revised ApplyDeployment Apr 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2020
@marun
Copy link
Contributor Author

marun commented Apr 22, 2020

Updated to use merged library-go change, PTAL.

@marun
Copy link
Contributor Author

marun commented Apr 23, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Apr 27, 2020

/retitle Bug 1827050: Update to use revised ApplyDeployment

@openshift-ci-robot openshift-ci-robot changed the title Update to use revised ApplyDeployment Bug 1827050: Update to use revised ApplyDeployment Apr 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 27, 2020

@marun: This pull request references Bugzilla bug 1827050, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1827050: Update to use revised ApplyDeployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2020
@marun
Update to use revised ApplyDeployment
26be2bf 
The new method hashes the spec of the deployment which removes the
need for considering generation or forcing rollout.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2020
@marun
Copy link
Contributor Author

marun commented Apr 29, 2020

Rebased, PTAL

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2020

@marun: This pull request references Bugzilla bug 1827050, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1827050: Update to use revised ApplyDeployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Apr 29, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit fd78e82 into openshift:master Apr 29, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2020

@marun: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1827050: Update to use revised ApplyDeployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marun @openshift-ci-robot @sttts @openshift-merge-robot