OCPBUGS-43892: manual rebase on upstream release-0.11 #331
Conversation
…anup-e2e-tests 🌱 Ensure E2E cleanup
The v1alpha7 tests were previously testing v1alpha6.
⚠️ Remove v1alpha5
🐛 Fix v1alpha7 e2e tests
🌱 Bump CAPI to v1.7.0
Signed-off-by: Jan Schoone <[email protected]>
…_outdated_warnings 📖 remove outdated warnings
This commit makes security linting easier by never setting a TLS version outside v1.2 or v1.3, even in case of an unacceptable user input.
🌱 Refactoring: never assign unacceptable TLS versions
…cated⚠️ Deprecate v1alpha7
…sion-proposal 📖 Proposal for microversion support
Also adds fuzz tests which would have caught this and any similar issues.
🐛 Fix webhook panic when adding managed security groups
…rved⚠️ Don't serve v1alpha6
🌱 Bump Golang CI Lint to v1.57.2
🌱 Bump Gophercloud to v1.11.0
🐛 Remove a duplication for setting default port settings
It's some work we're preparing to build a new controller in charge of creating servers and their dependencies (ports, etc). We don't want it to depent on the OpenStack Machine object.
it's better to not have these instead of having them outdated See https://kubernetes.slack.com/archives/CFKJB65G9/p1714665937168969?thread_ts=1694426926.778949&cid=CFKJB65G9
Drop this after v0.11, as these are no longer present in main.
Generated with:
cd hack/codegen
go mod tidy
go work vendor
cd ../../orc/hack/codegen
go mod tidy
go work vendor
openshift-ci-robot
added
the
jira/valid-reference
|
@mandre: This pull request references Jira Issue OCPBUGS-43892, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
| return nil, fmt.Errorf("listing control plane machines: %w", err) | ||
| } | ||
|
|
||
| if mapiMachines.Items == nil { |
There was a problem hiding this comment.
This should be
if len(mapiMachines.Items) == 0 {Comparing a slice to nil is almost never correct.
When getting the subnet from machines, let's return an error if no control plane machine was found. This will make it clearer when debugging.
EmilienM
force-pushed
the
sync-main-martin
branch
from
c0b1631 to
a8678cb
Compare
|
Looking at the logs from the last run, I see a couple of issues: Errors in capo-controller-manager Also some cert issues Eventually, CAPO stops: That likely explains the webhook errors we see in the capi-controller-manager logs: |
|
We load the ORC CRDs from the However, I vaguely recall we don't use the |
Co-Authored-By: Matthew Booth <[email protected]>
mandre
force-pushed
the
sync-main-martin
branch
from
9dbf400 to
44509be
Compare
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
discussed with Matt offline, we decided to ship it. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mandre: Jira Issue OCPBUGS-43892: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-43892 has been moved to the MODIFIED state. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
After the fact, but |
|
[ART PR BUILD NOTIFIER] Distgit: openstack-cluster-api-controllers |
20 participants
Supersedes #326 and #330