Skip to content

🐛 Fix v1alpha7 e2e tests #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Apr 18, 2024
Merged

🐛 Fix v1alpha7 e2e tests #2028

k8s-ci-robot merged 1 commit into from
Apr 18, 2024

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Apr 17, 2024

The v1alpha7 tests were previously testing v1alpha6.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 803d45e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6620da6f23bc5900089747b5
😎 Deploy Preview https://deploy-preview-2028--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot requested review from dulek and lentzi90 April 17, 2024 18:46
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 17, 2024

/cherry-pick release-0.10

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Apr 17, 2024

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 17, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth
Fix v1alpha7 e2e tests
803d45e 
The v1alpha7 tests were previously testing v1alpha6.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@mdbooth mdbooth changed the title Fix v1alpha7 e2e tests 🐛 Fix v1alpha7 e2e tests Apr 18, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth mdbooth mentioned this pull request Apr 18, 2024
Merged
1 task
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
lentzi90
lentzi90 reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

/test pull-cluster-api-provider-openstack-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit a5e83f2 into kubernetes-sigs:main Apr 18, 2024
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Apr 18, 2024

@mdbooth: new pull request created: #2031

Details

In response to this:

/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 18, 2024
Merged
@mdbooth mdbooth deleted the v1alpha7e2e branch April 18, 2024 15:21
@kashifest kashifest mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@dulek dulek Awaiting requested review from dulek

Assignees

@lentzi90 lentzi90

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

CAPO Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdbooth @k8s-infra-cherrypick-robot @k8s-ci-robot @lentzi90