OCPBUGS-43892: manual rebase on upstream release-0.11 #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a proposal for how CAPO could support more than one microversion. The current situation is that we hard code a microversion that is then used for all API calls. This is currently done for Nova. Other clients are not configured with a version as of now.
Signed-off-by: Huy Mai <huy.mai@est.tech>
…anup-e2e-tests 🌱 Ensure E2E cleanup
The v1alpha7 tests were previously testing v1alpha6.
⚠️ Remove v1alpha5
🐛 Fix v1alpha7 e2e tests
🌱 Bump CAPI to v1.7.0
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
…_outdated_warnings 📖 remove outdated warnings
This commit makes security linting easier by never setting a TLS version outside v1.2 or v1.3, even in case of an unacceptable user input.
🌱 Refactoring: never assign unacceptable TLS versions
…cated⚠️ Deprecate v1alpha7
…sion-proposal 📖 Proposal for microversion support
Also adds fuzz tests which would have caught this and any similar issues.
🐛 Fix webhook panic when adding managed security groups
…rved⚠️ Don't serve v1alpha6
🌱 Bump Golang CI Lint to v1.57.2
🌱 Bump Gophercloud to v1.11.0
🐛 Remove a duplication for setting default port settings
It's some work we're preparing to build a new controller in charge of creating servers and their dependencies (ports, etc). We don't want it to depent on the OpenStack Machine object.
In addition to vendor directories, we can ignore things that do not end up in the product. Co-Authored-By: Martin André <m.andre@redhat.com>
This is required for it to be included in the release payload. CAPO is actually deployed by cluster-capi-operator, but is not directly referenced by cluster-capi-operator. cluster-capi-operator instead consumes a ConfigMap deployed by CAPO. CAPO must be included in the release payload in order for cluster-capi-operator to be able to consume this ConfigMap.
Also fix lint issues hightlighted by these tests.
This is step 1 of 3 in the dance necessary to add e2e tests. Next up, the job definition itself (in 'openshift/release'). Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
These are heavily based on the tests for other platforms, which are currently included in the cluster-capi-operator tree [1] but which will eventually be moved out to the openshift forks of the respective CAPI implementations. The key difference from these is that (a) we don't create a cluster (since we have the infracluster controller for this) and (b) we obviously use OpenStack-specific semantics. [1] https://github.com/openshift/cluster-capi-operator/tree/release-4.15/e2e Co-Authored-By: Emilien Macchi <emilien@redhat.com> Co-Authored-By: Stephen Finucane <stephenfin@redhat.com>
As in openshift/cluster-version-operator@48fe9f2669 (install: Drop single-node-developer profile, 2021-11-05, openshift/cluster-version-operator#685). There's an enhancement proposal for this profile [1], and the Code Ready Containers folks took a run at using it in [2] before backing off in [3]. I don't have any problems with having a specific CRC profile, but if we end up going that way, we'll need a lot more manifests with the annotation (e.g. we'll probably also want the CVO manifests to include this annotation, or there won't be anything consuming the admin-ack ConfigMaps ;). This commit drops the annotation from this repository to avoid distracting folks with dead code. [1]: https://github.com/openshift/enhancements/blob/2911c46bf7d2f22eb1ab81739b4f9c2603fd0c07/enhancements/single-node/developer-cluster-profile.md [2]: crc-org/snc#338 [3]: crc-org/snc#373 (comment)
openshift/machine-api-operator@9c20871740 (annotate cloud credentials request, 2023-11-14, openshift/machine-api-operator#1174) added this capability to the machine-API analog of this manifest. And openshift/cluster-capi-operator@e305541274 (annotate credentials request manifests, 2023-11-13, openshift/cluster-capi-operator#143) annotated some cluster-API CredentialsRequests used for other providers. This commit catches cluster-API OpenStack up with those other changes. There is a risk that tech-preview clusters updating into this change will have the CloudCredential capability implicitly enabled. But because TechPreviewNoUpgrade blocks minor updates, and we don't intend to backport this to 4.14.z, that exposure is confined to unsuported prerelease clusters.
mandre
force-pushed
the
sync-main-martin
branch
2 times, most recently
from
137281e to
c26c73c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mandre
force-pushed
the
sync-main-martin
branch
2 times, most recently
from
4ab4afe to
54c7ee5
Compare
Co-Authored-By: Martin André <m.andre@redhat.com>
Drop this after v0.11, as these are no longer present in main.
Generated with:
cd hack/codegen
go mod tidy
go work vendor
cd ../../orc/hack/codegen
go mod tidy
go work vendor
mandre
force-pushed
the
sync-main-martin
branch
from
54c7ee5 to
8ce1418
Compare
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
I unfortunately pushed the branch into the wrong repo :-/ |
|
@mandre: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mandre: This pull request references Jira Issue OCPBUGS-43892. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #326