Skip to content

Bug 1933667: Update ose-openstack-machine-controllers builder & base images to be consistent with ART #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 18, 2021
Merged

Bug 1933667: Update ose-openstack-machine-controllers builder & base images to be consistent with ART #154

openshift-merge-robot merged 1 commit into from
Mar 18, 2021

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Jan 14, 2021 •
edited
Loading

Completes #165

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jan 14, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

@pierreprinetti: This pull request references Bugzilla bug 1915925, which is invalid:

  • expected dependent Bugzilla bug 1915926 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 14, 2021
@pierreprinetti pierreprinetti mentioned this pull request Jan 14, 2021
Closed
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 14, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

@pierreprinetti: This pull request references Bugzilla bug 1915925, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1915926 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1915926 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 14, 2021
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jan 14, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

@pierreprinetti: This pull request references Bugzilla bug 1915925, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1915926 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1915926 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti mentioned this pull request Jan 14, 2021
Closed
mandre
mandre reviewed Jan 14, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
This was referenced Jan 14, 2021
Closed
Closed
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@pierreprinetti pierreprinetti changed the title Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART Bug 1933667: Update ose-openstack-machine-controllers builder & base images to be consistent with ART Mar 1, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2021

@pierreprinetti: This pull request references Bugzilla bug 1933667, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1915926 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1915926 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents
Details

In response to this:

Bug 1933667: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2021

@pierreprinetti: This pull request references Bugzilla bug 1933667, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1915926 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1915926 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents
Details

In response to this:

Bug 1933667: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Mar 1, 2021

/retest

1 similar comment
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Mar 1, 2021

/retest

Fedosin
Fedosin approved these changes Mar 2, 2021
View reviewed changes
Copy link

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@mdbooth
Copy link

mdbooth commented Mar 2, 2021

/lgtm

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 17, 2021
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Mar 17, 2021

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 18, 2021
Merged
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Mar 18, 2021

/retest

1 similar comment
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Mar 18, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 48b7341 into openshift:release-4.6 Mar 18, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2021

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1933667 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1933667: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the base_image_4.6 branch March 18, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@adduarte adduarte Awaiting requested review from adduarte

+1 more reviewer

@Fedosin Fedosin Fedosin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@mdbooth mdbooth

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pierreprinetti @openshift-ci-robot @mdbooth @mandre @Fedosin @ecordell @openshift-merge-robot