Skip to content

Updating ose-openstack-machine-controllers builder & base images to be consistent with ART #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-bot wants to merge 1 commit into from
Closed

Updating ose-openstack-machine-controllers builder & base images to be consistent with ART #158

openshift-bot wants to merge 1 commit into from

Conversation

@openshift-bot
Copy link

@openshift-bot openshift-bot commented Jan 14, 2021

Updating ose-openstack-machine-controllers builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/5bab2562bbfa5695509be4f1de8c6c92d0dd2867/images/ose-openstack-machine-controllers.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@openshift-bot openshift-bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 14, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Updating ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fedosin after the PR has been reviewed.
You can assign the PR to them by writing /assign @fedosin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Member

pierreprinetti commented Jan 14, 2021

/close
#154

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

@pierreprinetti: Closed this PR.

Details

In response to this:

/close
#154

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@flaper87 @pierreprinetti
Get user-data/startupScripts from secrets (openshift#173)
974b0e7 
This commit adds the ability to pass custom userData/startupScripts to
the machines using kubernetes secrets. The previous workflow that used
the machine-setup ConfigMap has been removed in favor of the new one.

Fixes openshift#158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

No one assigned

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-bot @openshift-ci-robot @pierreprinetti