Skip to content

Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-bot wants to merge 1 commit into from
Closed

Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART #150

openshift-bot wants to merge 1 commit into from

Conversation

@openshift-bot
Copy link

@openshift-bot openshift-bot commented Jan 13, 2021 •
edited
Loading

Updating ose-openstack-machine-controllers builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/4a98c8d67fb1b0233d689c4bcc7f97e61da53999/images/ose-openstack-machine-controllers.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2021

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Updating ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pierreprinetti after the PR has been reviewed.
You can assign the PR to them by writing /assign @pierreprinetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Member

pierreprinetti commented Jan 13, 2021

/retitle Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

@openshift-ci-robot openshift-ci-robot changed the title Updating ose-openstack-machine-controllers builder & base images to be consistent with ART Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART Jan 13, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2021

@openshift-bot: This pull request references Bugzilla bug 1915925, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "4.7.0" instead
  • expected Bugzilla bug 1915925 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 13, 2021
@pierreprinetti
Copy link
Member

pierreprinetti commented Jan 13, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2021

@pierreprinetti: This pull request references Bugzilla bug 1915925, which is invalid:

  • expected Bugzilla bug 1915925 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

pierreprinetti commented Jan 13, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2021

@pierreprinetti: This pull request references Bugzilla bug 1915925, which is invalid:

  • expected dependent Bugzilla bug 1915926 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.6-ose-openstack-machine-controllers branch from 09b751a to 76fc1ce Compare January 14, 2021 04:49
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

@openshift-bot: This pull request references Bugzilla bug 1915925, which is invalid:

  • expected dependent Bugzilla bug 1915926 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1915925: Update ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2021

@openshift-bot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 76fc1ce link /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

pierreprinetti commented Jan 14, 2021

/close
Superseded by #154

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2021

@pierreprinetti: Closed this PR.

Details

In response to this:

/close
Superseded by #154

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@pierreprinetti
Basic cluster reconciler (openshift#150)
28e708b 
* Basic implementation of creating networks

Added ports for subnets to router

Implemented cluster update

Replaced glog by klog

Changed usage of NetworService

Now Reconcile creates an instance of NetworkService on each run. So in
theory it will be possible to configure OS-Credentials per cluster.

Added router to ClusterStatus

Changed to only one Router

Resynced Gopkg.lock

Improved logs

Reconciling of networks now log the default log level

Added Docs to ClusterStatus.Network

Recreated zz_generated with new types

* Migrated to params of PR 136

* removed unneeded line

* Updated Network to only hold a single subnet

At the current point in time, we don't need multiple subnets, and we are
not even able to configure them.

Beside this, I refactored the reconciling code to return network, subnet
and router instead of manipulating pointer data.

* Removed unneeded clusterclient in favor of runtime.Client

See also
kubernetes-retired/kubefed#208 (comment)

We don't need the clientset_generated any more.

* Fixed typos, re-ordered fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

1 more reviewer

@pierreprinetti pierreprinetti pierreprinetti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-bot @openshift-ci-robot @pierreprinetti