Merged
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
…booted Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
- add InfraClusterSecretRef to KubevirtClusterSpec - add example template - add InfraCluster construct to incapsulate infra cluster client and context - move cluster management resource cleanup logic to `reconcileDelete` func in controllers - enhance logging Signed-off-by: Alex Gradouski <agradouski@apple.com>
…hecked Signed-off-by: David Vossel <davidvossel@gmail.com>
- return on errors, with retries Signed-off-by: Alex Gradouski <agradouski@apple.com>
Make ssh bootstrap detection optional
Update README.md
Add unit- and functional test runners based on github actions
added meeting info to the README
If a PR gets labeled with `ok-to-test` the integration test job is triggered and this github action has access to secrets. The github action does for security resaons not allow secrets on all PRs, so we add this extra step. Still, the action itself, while using a secret, does not have any interaction points with users. The PR content is actually not even checked out. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Make secrets for third-party PRs available
Signed-off-by: David Vossel <davidvossel@gmail.com>
…ation Signed-off-by: David Vossel <davidvossel@gmail.com>
Add Dockerfile to build manager binary and emit production image
Fixes "failed to create VM instance" error
With the new Dockerfile in place which builds the manager binary, the binary does not have to be built upfront with the external golang version. Instead the internal one can be used which makes for instance integration jobs independent of the go versions installed there. Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
…-external-golang Make integration tests independent of go version changes
Meetings Details update in README.md
Signed-off-by: Alex Gradouski <agradouski@apple.com>
Support for external infra clusters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rmohr
reviewed
Dec 20, 2021
| repository: kubevirt/project-infra | ||
| path: project-infra | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v1 |
There was a problem hiding this comment.
Will be interesting to see if github actions will be used here too. We potentially have to delete them.
Author
There was a problem hiding this comment.
Easy to prevent by adding
if: (github.repository == 'kubernetes-sigs/cluster-api-provider-kubevirt')
in the kubernetes-sigs repo
|
@nunnatsa: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release notes: