Make integration tests independent of go version changes#53
Conversation
With the new Dockerfile in place which builds the manager binary, the binary does not have to be built upfront with the external golang version. Instead the internal one can be used which makes for instance integration jobs independent of the go versions installed there. Signed-off-by: Roman Mohr <rmohr@redhat.com>
|
/cc @cchengleo /cc @nirarg @nirarg once this PR is in, you also need to bump the golang version in the Dockerfile in PR #50: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/Dockerfile#L19 We are referencing the golang versions still in too many places, but we will get to a more sane model :) |
|
@rmohr: GitHub didn't allow me to request PR reviews from the following users: nirarg. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Roman Mohr <rmohr@redhat.com>
davidvossel
left a comment
There was a problem hiding this comment.
/lgtm
yep, we don't need the make manager now that make docker-build uses the multi stage docker build. Thanks
|
@davidvossel: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think later we should unify the default golang version for the repo. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cchengleo, rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Thanks @rmohr |
…r-api-provider-kubevirt-mce-25 Red Hat Konflux update cluster-api-provider-kubevirt-mce-25
What this PR does / why we need it:
With the new Dockerfile in place with #46 which builds the manager binary, the
binary does not have to be built upfront with the external golang
version. Instead the internal one can be used which makes for instance
integration jobs independent of the go versions installed there.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release notes: