Skip to content

Make integration tests independent of go version changes#53

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
rmohr:integration-tests-no-external-golang
Dec 19, 2021
Merged

Make integration tests independent of go version changes#53
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
rmohr:integration-tests-no-external-golang

Conversation

@rmohr
Copy link
Copy Markdown
Contributor

@rmohr rmohr commented Dec 17, 2021

What this PR does / why we need it:

With the new Dockerfile in place with #46 which builds the manager binary, the
binary does not have to be built upfront with the external golang
version. Instead the internal one can be used which makes for instance
integration jobs independent of the go versions installed there.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

NONE

With the new Dockerfile in place which builds the manager binary, the
binary does not have to be built upfront with the external golang
version. Instead the internal one can be used which makes for instance
integration jobs independent of the go versions installed there.

Signed-off-by: Roman Mohr <rmohr@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2021
@rmohr
Copy link
Copy Markdown
Contributor Author

rmohr commented Dec 17, 2021

/cc @cchengleo

/cc @nirarg

@nirarg once this PR is in, you also need to bump the golang version in the Dockerfile in PR #50: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/Dockerfile#L19

We are referencing the golang versions still in too many places, but we will get to a more sane model :)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@rmohr: GitHub didn't allow me to request PR reviews from the following users: nirarg.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @cchengleo

/cc @nirarg

@nirarg once this PR is in, you also need to bump the golang version in the Dockerfile in PR #50: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/Dockerfile#L19

We are referencing the golang versions still in too many places, but we will get to a more sane model :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Roman Mohr <rmohr@redhat.com>
Copy link
Copy Markdown
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

yep, we don't need the make manager now that make docker-build uses the multi stage docker build. Thanks

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@davidvossel: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

yep, we don't need the make manager now that make docker-build uses the multi stage docker build. Thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cchengleo
Copy link
Copy Markdown
Contributor

@nirarg once this PR is in, you also need to bump the golang version in the Dockerfile in PR #50: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/Dockerfile#L19

We are referencing the golang versions still in too many places, but we will get to a more sane model :)

I think later we should unify the default golang version for the repo.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cchengleo, rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2021
@cchengleo
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5a94245 into kubernetes-sigs:main Dec 19, 2021
@nirarg
Copy link
Copy Markdown
Contributor

nirarg commented Dec 19, 2021

@nirarg once this PR is in, you also need to bump the golang version in the Dockerfile in PR #50: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/Dockerfile#L19

Thanks @rmohr
I changed the version in my PR

davidvossel pushed a commit to davidvossel/cluster-api-provider-kubevirt-1 that referenced this pull request Jun 12, 2024
…r-api-provider-kubevirt-mce-25

Red Hat Konflux update cluster-api-provider-kubevirt-mce-25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants