Make secrets for third-party PRs available#49
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Contributor
Author
|
/cc @cchengleo |
If a PR gets labeled with `ok-to-test` the integration test job is triggered and this github action has access to secrets. The github action does for security resaons not allow secrets on all PRs, so we add this extra step. Still, the action itself, while using a secret, does not have any interaction points with users. The PR content is actually not even checked out. Signed-off-by: Roman Mohr <rmohr@redhat.com>
rmohr
force-pushed
the
make-secrets-available
branch
from
bff238d to
37a448c
Compare
k8s-ci-robot
added
lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cchengleo, rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nunnatsa
pushed a commit
to nunnatsa/cluster-api-provider-kubevirt
that referenced
this pull request
Nov 14, 2023
…m_2023-10-22-06-29 CNV-33675: Auto sync upstream 2023 10 22 06 29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a PR gets labeled with
ok-to-testthe integration test job istriggered and this github action has access to secrets.
The github action does for security resaons not allow secrets on all
PRs, so we add this extra step.
Still, the action itself, while using a secret, does not have any
interaction points with users. The PR content is actually not even
checked out.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Also see https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ for more details and being able to judge for yourself if you consider this safe.
Release notes: