stop generating CRDs for provider spec and status#140
stop generating CRDs for provider spec and status#140openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
approved
|
/cc @rdoxenham |
dhellmann
force-pushed
the
drop-manifest-generation
branch
from
6d6f2be to
58d9c84
Compare
We do not use separate CRDs for the provider spec or status for Machine resources. They are being generated with settings that are no longer supported, which breaks our ability to upgrade the dependencies in this repo. See kubernetes/enhancements#1111 Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
dhellmann
force-pushed
the
drop-manifest-generation
branch
from
58d9c84 to
9ed069a
Compare
rdoxenham
left a comment
rdoxenham
left a comment
There was a problem hiding this comment.
Thanks for taking the time to do this!
|
/test e2e-metal-ipi |
|
/retest |
|
These types definitely don't exist in the deployed cluster - I was wondering why these existed :) /approve |
|
/test e2e-metal-ipi |
|
@dhellmann: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-metal-ipi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, hardys, rdoxenham, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🐛 Fix incorrect variable in the doc
7 participants
We do not use separate CRDs for the provider spec or status for
Machine resources. They are being generated with settings that are no
longer supported, which breaks our ability to upgrade the dependencies
in this repo.
See kubernetes/enhancements#1111