Bug 1936844: [release-4.7] Changing the default behaviour of the CAPBM to request hard reboot by rdoxenham · Pull Request #144 · openshift/cluster-api-provider-baremetal

rdoxenham · 2021-03-09T10:44:52Z

This is a manual cherry-pick of #138, to bring the recent CAPBM changes to support reboot mode back to 4.7.

Note that I'm pulling #140 back into 4.7 with this PR as it's a requirement; we removed this in 4.8 but I don't think that it will cause problems in 4.7 either?

This will need to wait for openshift/baremetal-operator#132 to merge.

We do not use separate CRDs for the provider spec or status for Machine resources. They are being generated with settings that are no longer supported, which breaks our ability to upgrade the dependencies in this repo. See kubernetes/enhancements#1111 Signed-off-by: Doug Hellmann <dhellmann@redhat.com>

In this commit we're pulling in the latest version of the BMO dependencies via the vendor module, allowing us to utilise newer functions and structs provided by recent PR's in the latest BMO code. This updates to v0.0.0-20210303141721-86a42dcb0150.

This change adds an additional mode to the reboot annotation that forces all nodes sent for remediation, e.g. via a MachineHealthCheck, to be forcefully rebooted rather than defaulting to a soft reboot first, as it is today. The primary drive behind this change is to enable quicker recovery of workloads, e.g. for high-availability use cases, and by defaulting to forced hard reboot we can enable functionality very close to fencing. This change shouldn't impact any other non-remediation reboot requests, as the hard reboot functionality only takes place when the mode=hard annotation is applied to the node. All of the work on the BMO can be found in the link below. Whilst we depend on this PR to have a complete solution, we don't have a hard dependency on them merging together. BMO PR: metal3-io/baremetal-operator#795

openshift-ci-robot · 2021-03-09T10:44:53Z

@rdoxenham: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.7] Changing the default behaviour of the CAPBM to request hard reboot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rdoxenham · 2021-03-09T10:56:46Z

/retitle Bug 1936844: [release-4.7] Changing the default behaviour of the CAPBM to request hard reboot

openshift-ci-robot · 2021-03-09T10:57:02Z

@rdoxenham: This pull request references Bugzilla bug 1936844, which is invalid:

expected dependent Bugzilla bug 1936407 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1936407 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1936844: [release-4.7] Changing the default behaviour of the CAPBM to request hard reboot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rdoxenham · 2021-03-09T15:05:56Z

/retest

rdoxenham · 2021-03-09T21:53:09Z

/bugzilla refresh

openshift-ci-robot · 2021-03-09T21:53:13Z

@rdoxenham: This pull request references Bugzilla bug 1936844, which is invalid:

expected dependent Bugzilla bug 1937122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rdoxenham · 2021-03-15T09:57:53Z

/bugzilla refresh

openshift-ci-robot · 2021-03-15T09:57:58Z

@rdoxenham: This pull request references Bugzilla bug 1936844, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1937122 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1937122 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2021-03-15T12:06:31Z

/approve
/lgtm

dhellmann · 2021-03-15T13:30:52Z

/approve

openshift-ci-robot · 2021-03-15T13:31:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, rdoxenham, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dhellmann]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rdoxenham · 2021-03-15T13:58:22Z

Please make sure this gets backported/selected for 4.7.z at the same time as openshift/baremetal-operator#132

openshift-ci-robot · 2021-03-18T20:55:50Z

@rdoxenham: This pull request references Bugzilla bug 1936844, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1937122 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1937122 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

Details

In response to this:

Bug 1936844: [release-4.7] Changing the default behaviour of the CAPBM to request hard reboot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-19T20:47:49Z

/retest