[release-4.7] Changing the default behaviour of the CAPBM to request hard reboot#143
Conversation
In this commit we're pulling in the latest version of the BMO dependencies via the vendor module, allowing us to utilise newer functions and structs provided by recent PR's in the latest BMO code. This updates to v0.0.0-20210303141721-86a42dcb0150.
This change adds an additional mode to the reboot annotation that forces all nodes sent for remediation, e.g. via a MachineHealthCheck, to be forcefully rebooted rather than defaulting to a soft reboot first, as it is today. The primary drive behind this change is to enable quicker recovery of workloads, e.g. for high-availability use cases, and by defaulting to forced hard reboot we can enable functionality very close to fencing. This change shouldn't impact any other non-remediation reboot requests, as the hard reboot functionality only takes place when the mode=hard annotation is applied to the node. All of the work on the BMO can be found in the link below. Whilst we depend on this PR to have a complete solution, we don't have a hard dependency on them merging together. BMO PR: metal3-io/baremetal-operator#795
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I will need to create a separate PR for this as I need to pull in #140 manually. |
|
/close |
|
@hardys: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🐛 Update dev-setup.md
4 participants
This is an automated cherry-pick of #138
/assign rdoxenham