-
Notifications
You must be signed in to change notification settings - Fork 654
Change default az to empty when create cinder volume #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
713a02c to
2cca5c9
Compare
2cca5c9 to
9ebc7b7
Compare
|
signed |
zetaab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not fully sure should this PR be implemented like this. 90% of openstack users with kubernetes are using cinders as is for now. If this is changed like this, there is not backward compatibility and it means that it will break things.
Also what is behaviour is az is empty? Will it fail or will it just take first az from the cinder list? @animationzl so you have cinder az name something different than nova? Then imo we should not modify this behaviour, instead you can use parameters to specify and override the az.
|
/assign @aglitke |
|
@dims: GitHub didn't allow me to assign the following users: aglitke. Note that only kubernetes members and repo collaborators can be assigned. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
@zetaab Note that this is the new external volume service, not the regular cinder one from the main k/k. So no one is using this yet. |
|
/ok-to-test |
|
@dims ok but still I would like to get answer how it behaves if az is empty. |
|
@animationzl please respond to @zetaab 's question |
|
@zetaab yes, the cloud provider I use has a different az name than nova, the default az in cinder create api is None, when creating volume without a specific az(such as |
|
ok then I can approve that change :) |
|
/approve @dims add LGTM if you think this is ok to merge |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change default az to empty when create cinder volume
Bug 1996783: Bump to Go v1.16 and OCP v4.9
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #72Special notes for your reviewer:
Release note: