Skip to content

Conversation

@animationzl
Copy link
Contributor

@animationzl animationzl commented Mar 30, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #72

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 30, 2018
@animationzl
Copy link
Contributor Author

signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 30, 2018
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fully sure should this PR be implemented like this. 90% of openstack users with kubernetes are using cinders as is for now. If this is changed like this, there is not backward compatibility and it means that it will break things.

Also what is behaviour is az is empty? Will it fail or will it just take first az from the cinder list? @animationzl so you have cinder az name something different than nova? Then imo we should not modify this behaviour, instead you can use parameters to specify and override the az.

@dims
Copy link
Member

dims commented Mar 31, 2018

/assign @aglitke

@k8s-ci-robot
Copy link
Contributor

@dims: GitHub didn't allow me to assign the following users: aglitke.

Note that only kubernetes members and repo collaborators can be assigned.

Details

In response to this:

/assign @aglitke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Mar 31, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2018
@dims
Copy link
Member

dims commented Mar 31, 2018

@zetaab Note that this is the new external volume service, not the regular cinder one from the main k/k. So no one is using this yet.

@dims
Copy link
Member

dims commented Mar 31, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2018
@zetaab
Copy link
Member

zetaab commented Mar 31, 2018

@dims ok but still I would like to get answer how it behaves if az is empty.

@dims
Copy link
Member

dims commented Mar 31, 2018

@animationzl please respond to @zetaab 's question

@animationzl
Copy link
Contributor Author

@zetaab yes, the cloud provider I use has a different az name than nova, the default az in cinder create api is None, when creating volume without a specific az(such as cinder create 1), a random az of specific volume host which the volume is scheduled to will be chose as result.

@zetaab
Copy link
Member

zetaab commented Mar 31, 2018

ok then I can approve that change :)

@zetaab
Copy link
Member

zetaab commented Mar 31, 2018

/approve

@dims add LGTM if you think this is ok to merge

@dims
Copy link
Member

dims commented Mar 31, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9cb59ef into kubernetes:master Mar 31, 2018
@animationzl animationzl deleted the change-default-az branch April 2, 2018 01:40
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Change default az to empty when create cinder volume
dulek pushed a commit to dulek/cloud-provider-openstack that referenced this pull request Sep 6, 2022
Bug 1996783: Bump to Go v1.16 and OCP v4.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create cinder volume failed with default availability zone 'nova'

4 participants