Skip to content

TRT-1828: Revert #90 "OCPCLOUD-2725: Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master" #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Sep 24, 2024
Merged

TRT-1828: Revert #90 "OCPCLOUD-2725: Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master" #95

openshift-merge-bot merged 1 commit into from
Sep 24, 2024

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Sep 24, 2024 •
edited by openshift-ci bot
Loading

Reverts #90 ; tracked by TRT-1828

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift breakage due to rebase

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Ensure hypershift passes

CC: @cloud-team-rebase-bot[bot]

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#90 from openshift-cloud-team/reb…
ca2c4e6 
…ase-bot-master"

This reverts commit 6339775, reversing
changes made to 876afc6.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024

@stbenjam: This pull request explicitly references no jira issue.

Details

In response to this:

Reverts #90 ; tracked by NO-JIRA

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift breakage due to rebase

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Ensure hypershift passes

CC: @cloud-team-rebase-bot[bot]

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam stbenjam changed the title NO-JIRA: Revert #90 "OCPCLOUD-2725: Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master" TRT-1828: Revert #90 "OCPCLOUD-2725: Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master" Sep 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1828 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Reverts #90 ; tracked by NO-JIRA

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift breakage due to rebase

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Ensure hypershift passes

CC: @cloud-team-rebase-bot[bot]

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member Author

stbenjam commented Sep 24, 2024

/override ci/prow/verify-commits
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn
/label approved

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1828 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Reverts #90 ; tracked by TRT-1828

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift breakage due to rebase

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Ensure hypershift passes

CC: @cloud-team-rebase-bot[bot]

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-upgrade, ci/prow/verify-commits

Details

In response to this:

/override ci/prow/verify-commits
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link

JoelSpeed commented Sep 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 253e4ba into openshift:master Sep 24, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2024

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed JoelSpeed mentioned this pull request Sep 24, 2024
Merged
@wking wking mentioned this pull request Sep 24, 2024
Merged
4 tasks
@sjenning sjenning mentioned this pull request Sep 24, 2024
Merged
@openshift-bot
Copy link

openshift-bot commented Sep 24, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-cloud-controller-manager
This PR has been included in build ose-aws-cloud-controller-manager-container-v4.18.0-202409242009.p0.g253e4ba.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stbenjam @openshift-ci-robot @JoelSpeed @openshift-bot