Skip to content

OCPCLOUD-2725: Reintroduce rebase to K8s 1.31 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Sep 25, 2024
Merged

OCPCLOUD-2725: Reintroduce rebase to K8s 1.31 #97

openshift-merge-bot merged 2 commits into from
Sep 25, 2024

Conversation

@JoelSpeed
Copy link

@JoelSpeed JoelSpeed commented Sep 24, 2024

This reverts #95 while adding an additional commit to fix the HyperShift issue we observed

JoelSpeed and others added 2 commits September 24, 2024 16:54
@JoelSpeed
UPSTREAM: <drop>: Revert "Revert "Merge pull request kubernetes#90 fr…
f02a2a7 
…om openshift-cloud-team/rebase-bot-master""

This reverts commit ca2c4e6.
@sjenning @JoelSpeed
UPSTREAM: 1028: Make metadata logging best-effort
14eadba 
GetInstanceIdentityDocument returns a fatal error when AWS_EC2_METADATA_DISABLED is true.
Make the logging best-effort and ignore errors from GetInstanceIdentityDocument.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024 •
edited by openshift-ci bot
Loading

@JoelSpeed: This pull request references OCPCLOUD-2725 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

This reverts #95 while adding an additional commit to fix the HyperShift issue we observed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Author

JoelSpeed commented Sep 24, 2024

/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2024

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ffccbd40-7a8d-11ef-9127-b079ac047e3a-0

@elmiko
Copy link

elmiko commented Sep 24, 2024

change lgtm, but looks like the images job got oom killed, we might need to bump it up

/test images

@JoelSpeed
Copy link
Author

JoelSpeed commented Sep 25, 2024

HyperShift job is green this time
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@Patryk-Stefanski
Copy link

Patryk-Stefanski commented Sep 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c395190 into openshift:master Sep 25, 2024
@openshift-bot
Copy link

openshift-bot commented Sep 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-cloud-controller-manager
This PR has been included in build ose-aws-cloud-controller-manager-container-v4.18.0-202409251142.p0.gc395190.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@Patryk-Stefanski Patryk-Stefanski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JoelSpeed @openshift-ci-robot @elmiko @Patryk-Stefanski @openshift-bot @sjenning