Skip to content

Conversation

@cloud-team-rebase-bot
Copy link

No description provided.

aupadhyay3 and others added 9 commits June 3, 2024 16:57
Co-Authored-By: Eric Wolak <eric.wolak@reddit.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
….22.4

Bump golang version to 1.22.4 for master branch
…-rbac

Grant cloud-controller-manager RBAC permissions for HTTP port access
Add kmala to the owners file
@openshift-ci openshift-ci bot requested review from nrb and racheljpg June 13, 2024 12:08
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2024

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/cloud-provider-aws:master (3e3ffe9) into master Merge https://github.com/kubernetes/cloud-provider-aws:master (5f2ebdf) into master Jun 20, 2024
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from 27accab to 89ffd82 Compare June 20, 2024 12:07
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/cloud-provider-aws:master (5f2ebdf) into master Merge https://github.com/kubernetes/cloud-provider-aws:master (f405df5) into master Jun 24, 2024
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch 2 times, most recently from 6d56b4a to dfe27e6 Compare June 27, 2024 12:07
kmala and others added 3 commits June 27, 2024 11:53
add support for new aws partitions in credential provider
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/cloud-provider-aws:master (f405df5) into master Merge https://github.com/kubernetes/cloud-provider-aws:master (7a4b309) into master Jul 1, 2024
@cloud-team-bot cloud-team-bot bot force-pushed the rebase-bot-master branch from dfe27e6 to 93947d4 Compare July 1, 2024 12:15
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/cloud-provider-aws:master (7a4b309) into master Merge https://github.com/kubernetes/cloud-provider-aws:master (a193970) into master Jul 4, 2024
@elmiko
Copy link

elmiko commented Sep 4, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2024
@elmiko
Copy link

elmiko commented Sep 4, 2024

seeing the failure to update load balancers issue again, still not quite sure about the root cause on this one.

/retest

@nrb
Copy link

nrb commented Sep 5, 2024

/retest

@elmiko
Copy link

elmiko commented Sep 6, 2024

talked about the load balancer issue in standup, we feel that the underlying issue is not caused by this PR but rather is a flake that we are still tracking down.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@JoelSpeed JoelSpeed changed the title Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master OCPCLOUD-2725: Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master Sep 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024

@cloud-team-rebase-bot[bot]: This pull request references OCPCLOUD-2725 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2024

@cloud-team-rebase-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6339775 into openshift:master Sep 23, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-cloud-controller-manager
This PR has been included in build ose-aws-cloud-controller-manager-container-v4.18.0-202409231711.p0.g6339775.assembly.stream.el9.
All builds following this will include this PR.

stbenjam added a commit to stbenjam/cloud-provider-aws that referenced this pull request Sep 24, 2024
…ase-bot-master"

This reverts commit 6339775, reversing
changes made to 876afc6.
openshift-merge-bot bot pushed a commit that referenced this pull request Sep 25, 2024
…ft-cloud-team/rebase-bot-master""

This reverts commit ca2c4e6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.