-
Notifications
You must be signed in to change notification settings - Fork 24
OCPCLOUD-2725: Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Eric Wolak <eric.wolak@reddit.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
….22.4 Bump golang version to 1.22.4 for master branch
…-rbac Grant cloud-controller-manager RBAC permissions for HTTP port access
…-1717978510 Update dependencies
Add kmala to the owners file
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…-1718583328 Update dependencies
27accab to
89ffd82
Compare
…-1719188153 Update dependencies
6d56b4a to
dfe27e6
Compare
add support for new aws partitions in credential provider
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dfe27e6 to
93947d4
Compare
format the instance metadata details log
|
/ok-to-test |
|
seeing the failure to update load balancers issue again, still not quite sure about the root cause on this one. /retest |
…onfiguration is provided
Adds .spec file for building the ecr credential provider. We build this using brew, and tooling from ART. This means we don't need to worry about setting env vars (e.g OS_GIT_VERSION) and where Source0 is set.
…r image to be consistent with ART for 4.18 Reconciling with https://github.com/openshift/ocp-build-data/tree/827ab4ccce9cbbcf82c9dbaf6398b61d6cff8d7a/images/ose-aws-cloud-controller-manager.yml
06c578a to
32239ad
Compare
|
/retest |
|
talked about the load balancer issue in standup, we feel that the underlying issue is not caused by this PR but rather is a flake that we are still tracking down. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cloud-team-rebase-bot[bot]: This pull request references OCPCLOUD-2725 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cloud-team-rebase-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-cloud-controller-manager |
TRT-1828: Revert #90 "OCPCLOUD-2725: Merge https://github.com/kubernetes/cloud-provider-aws:master (d7e05d5) into master"
…ft-cloud-team/rebase-bot-master"" This reverts commit ca2c4e6.
No description provided.